Subject: backupninja: Config defaults leads to node-exporter error

From: Olivier Berger <[email-masked]>
Date: Mon, 8 May 2023 20:58:53 +0200

Package: backupninja
Version: 1.2.2-1
Severity: minor
Tags: upstream

Dear Maintainer,

With the default config in backupninja.conf, and prometheus-node-exporter isn't installed, an error is reported at the end of backups like:
Error: /var/lib/prometheus/node-exporter does not exist!

I believe that the default value isn't suitable:
reportprom = false

Instead, it should be:
reportprom = 

if I interpret https://0xacab.org/liberate/backupninja/-/blob/8f81c85274cd7a21d4bff819bf800b300a7488d2/src/backupninja.in#L609 correctly.

Hope this is correct.

Best regards,

-- System Information:
Debian Release: 12.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'stable-security'), (500, 'testing'), (500, 'stable'), (100, 'bullseye-fasttrack'), (100, 'bullseye-backports-staging')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-7-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages backupninja depends on:
ii  bash    5.2.15-2+b2
ii  dialog  1.3-20230209-1
ii  gawk    1:5.2.1-2
ii  mawk    1.3.4.20200120-3.1

Versions of packages backupninja recommends:
ii  bsd-mailx [mailx]  8.1.2-0.20220412cvs-1
ii  mailutils [mailx]  1:3.15-4

Versions of packages backupninja suggests:
ii  borgbackup     1.2.4-1
ii  bzip2          1.0.8-5+b1
ii  debconf-utils  1.5.82
pn  duplicity      <none>
ii  fdisk          2.38.1-5+b1
ii  genisoimage    9:1.1.11-3.4
ii  hwinfo         21.82-1
ii  mdadm          4.2-5
ii  rdiff-backup   2.2.2-1
pn  restic         <none>
ii  rsync          3.2.7-1
pn  subversion     <none>
ii  trickle        1.07-12
ii  util-linux     2.38.1-5+b1
pn  wodim          <none>

-- Configuration Files:
/etc/backupninja.conf changed:
loglevel = 4
reportprom = 
reportemail = root
reportsuccess = yes
reportinfo = no
reportwarning = yes
reportspace = no
reporthost =
reportuser = ninja
reportdirectory = /var/lib/backupninja/reports
admingroup = root
logfile = /var/log/backupninja.log
configdirectory = /etc/backup.d
scriptdirectory = /usr/share/backupninja
libdirectory = /usr/lib/backupninja
usecolors = yes
when = everyday at 01:00

-- debconf-show failed

-- 
Olivier BERGER
https://www-public.imtbs-tsp.eu/~berger_o/ - OpenPGP 2048R/0xF9EAE3A65819D7E8
Ingenieur Recherche - Dept INF
Institut Mines-Telecom, Telecom SudParis, Evry (France)