Debian Bug report logs - #1051353
freecad: Can't create window in arch workbench

Full log

Message #17 received at [email protected] (full text, mbox, reply):

Received: (at 1051353) by bugs.debian.org; 7 Sep 2023 05:46:41 +0000
From [email protected] Thu Sep 07 05:46:41 2023
X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
	(2021-04-09) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=4.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
	SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no
	version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 17; hammy, 148; neutral, 44; spammy,
	0. spammytokens: hammytokens:0.000-+--reinholdtsen,
	0.000-+--Reinholdtsen, 0.000-+--H*RU:vuizook.err.no,
	0.000-+--H*r:vuizook.err.no, 0.000-+--H*F:D*hungry.com
Return-path: <[email protected]>
Received: from vuizook.err.no ([2a02:20c8:2640::2]:56406)
	by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1qe7qj-001mzg-OX
	for [email protected]; Thu, 07 Sep 2023 05:46:41 +0000
Received: from [84.212.193.114] (helo=hjemme.reinholdtsen.name)
	by vuizook.err.no with smtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <[email protected]>)
	id 1qe7qW-00DpQY-0S;
	Thu, 07 Sep 2023 05:46:34 +0000
Received: (nullmailer pid 1876598 invoked by uid 10001);
	Thu, 07 Sep 2023 05:46:26 -0000
From: Petter Reinholdtsen <[email protected]>
To: philippe <[email protected]>, [email protected]
Subject: Re: freecad: Can't create window in arch workbench
In-Reply-To: <[email protected]>
References: <169402690368.117361.17844500092972143746.reportbug@asus.opened-box.fr>
 <[email protected]>
Date: Thu, 07 Sep 2023 07:46:26 +0200
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain

Control: tags -1 + patch

For the record, I was mistaken about the problem also being present in
FreeCAD 0.21.  I was comparing against the wrong file locally to come to
this incorrect conclusion.  The follow change to the problematic
getargspec() calls are lifted from upstream.  Can you test to see if it
solve your problem?  There are other changes in 0.21 to this file, and I
am unsure if any of them are needed.  It might be a better idea to
upgrade FreeCAD in Debian to 0.21 instead of backporting this fix.

--- a/src/Mod/Draft/draftguitools/gui_snapper.py
+++ b/src/Mod/Draft/draftguitools/gui_snapper.py
@@ -1426,7 +1426,7 @@ class Snapper:
             Gui.Snapper.off()
             self.ui.offUi()
             if callback:
-                if len(inspect.getargspec(callback).args) > 1:
+                if len(inspect.getfullargspec(callback).args) > 1:
                     obj = None
                     if self.snapInfo and ("Object" in self.snapInfo) and self.snapInfo["Object"]:
                         obj = App.ActiveDocument.getObject(self.snapInfo["Object"])
@@ -1445,7 +1445,7 @@ class Snapper:
             Gui.Snapper.off()
             self.ui.offUi()
             if callback:
-                if len(inspect.getargspec(callback).args) > 1:
+                if len(inspect.getfullargspec(callback).args) > 1:
                     callback(None, None)
                 else:
                     callback(None)


-- 
Happy hacking
Petter Reinholdtsen

Send a report that this bug log contains spam.