Subject: astronomical-almanac: ftbfs with GCC-15

From: Matthias Klose <[email-masked]>
Date: Mon, 17 Feb 2025 17:03:58 +0000

Package: src:astronomical-almanac
Version: 5.6-8
Severity: important
Tags: sid forky
User: [email-masked]
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/astronomical-almanac_5.6-8_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |        ^~~~
In file included from kep.h:83,
                 from moonrise.c:7:
protos.h:72:15: note: previous declaration of ‘sqrt’ with type ‘double(double)’
   72 | extern double sqrt(double);
      |               ^~~~
moonrise.c:28:17: error: conflicting types for ‘asin’; have ‘double(void)’
   28 | double sqrt (), asin (), log ();
      |                 ^~~~
protos.h:67:15: note: previous declaration of ‘asin’ with type ‘double(double)’
   67 | extern double asin(double);
      |               ^~~~
moonrise.c:28:26: error: conflicting types for ‘log’; have ‘double(void)’
   28 | double sqrt (), asin (), log ();
      |                          ^~~
protos.h:74:15: note: previous declaration of ‘log’ with type ‘double(double)’
   74 | extern double log(double);
      |               ^~~
moonrise.c: In function ‘main’:
moonrise.c:149:11: error: too many arguments to function ‘search’; expected 0, have 1
  149 |       u = search (u);
      |           ^~~~~~  ~
moonrise.c:122:8: note: declared here
  122 | double search ();
      |        ^~~~~~
moonrise.c: In function ‘search’:
moonrise.c:169:1: warning: old-style function definition [-Wold-style-definition]
  169 | search (t)
      | ^~~~~~
moonrise.c:171:1: error: number of arguments doesn’t match prototype
  171 | {
      | ^
moonrise.c:122:8: error: prototype declaration
  122 | double search ();
      |        ^~~~~~
moonrise.c:183:3: error: too many arguments to function ‘func’; expected 0, have 1
  183 |   func (t);
      |   ^~~~  ~
moonrise.c:123:13: note: declared here
  123 | static void func ();
      |             ^~~~
moonrise.c:197:7: error: too many arguments to function ‘func’; expected 0, have 1
  197 |       func (t0);
      |       ^~~~  ~~
moonrise.c:123:13: note: declared here
  123 | static void func ();
      |             ^~~~
moonrise.c:223:7: error: too many arguments to function ‘func’; expected 0, have 1
  223 |       func (t0);
      |       ^~~~  ~~
moonrise.c:123:13: note: declared here
  123 | static void func ();
      |             ^~~~
moonrise.c:245:7: error: too many arguments to function ‘func’; expected 0, have 1
  245 |       func (t0);
      |       ^~~~  ~~
moonrise.c:123:13: note: declared here
  123 | static void func ();
      |             ^~~~
moonrise.c: In function ‘func’:
moonrise.c:263:1: warning: old-style function definition [-Wold-style-definition]
  263 | func (t)
      | ^~~~
make[2]: *** [<builtin>: moonrise.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/astronomical-almanac-5.6'
dh_auto_build: error: make -j1 "INSTALL=install --strip-program=true" moonrise conjunct aa returned exit code 2
make[1]: *** [debian/rules:13: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/astronomical-almanac-5.6'
make: *** [debian/rules:10: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2