Subject: ipip: ftbfs with GCC-15

From: Matthias Klose <[email-masked]>
Date: Mon, 17 Feb 2025 17:20:18 +0000

Package: src:ipip
Version: 1.1.13
Severity: important
Tags: sid forky
User: [email-masked]
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/ipip_1.1.13_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
  180 | int slip_open();
      |     ^~~~~~~~~
main.c:151:30: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  151 |         (void)signal(SIGINT, terminator);
      |                              ^~~~~~~~~~
      |                              |
      |                              void (*)(void)
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
main.c:34:13: note: ‘terminator’ declared here
   34 | static void terminator();
      |             ^~~~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
main.c:160:12: error: too many arguments to function ‘read_config’; expected 0, have 1
  160 |         if(read_config(configfile)<0){
      |            ^~~~~~~~~~~ ~~~~~~~~~~
ipip.h:198:5: note: declared here
  198 | int read_config();
      |     ^~~~~~~~~~~
main.c:181:12: error: too many arguments to function ‘read_routes’; expected 0, have 1
  181 |         if(read_routes(routefile)<0){
      |            ^~~~~~~~~~~ ~~~~~~~~~
ipip.h:195:5: note: declared here
  195 | int read_routes();
      |     ^~~~~~~~~~~
main.c:198:9: error: too many arguments to function ‘send_stats’; expected 0, have 1
  198 |         send_stats(1);
      |         ^~~~~~~~~~ ~
ipip.h:201:6: note: declared here
  201 | void send_stats();
      |      ^~~~~~~~~~
slip.c: In function ‘slip_read’:
slip.c:222:5: warning: old-style function definition [-Wold-style-definition]
  222 | int slip_read(ifp, m)
      |     ^~~~~~~~~
slip.c:225:1: error: number of arguments doesn’t match prototype
  225 | {
      | ^
ipip.h:182:5: error: prototype declaration
  182 | int slip_read();
      |     ^~~~~~~~~
slip.c:253:21: error: too many arguments to function ‘assemble_slip’; expected 0, have 2
  253 |                 n = assemble_slip(s, s->buffer[s->bnext]);
      |                     ^~~~~~~~~~~~~ ~
slip.c:76:12: note: declared here
   76 | static int assemble_slip();
      |            ^~~~~~~~~~~~~
slip.c: In function ‘slip_send’:
slip.c:275:5: warning: old-style function definition [-Wold-style-definition]
  275 | int slip_send(ifp, m)
      |     ^~~~~~~~~
slip.c:278:1: error: number of arguments doesn’t match prototype
  278 | {
      | ^
ipip.h:181:5: error: prototype declaration
  181 | int slip_send();
      |     ^~~~~~~~~
slip.c: In function ‘assemble_slip’:
slip.c:337:1: warning: old-style function definition [-Wold-style-definition]
  337 | assemble_slip(s, c)
      | ^~~~~~~~~~~~~
make[1]: *** [<builtin>: main.o] Error 1
make[1]: *** [<builtin>: slip.o] Error 1
make[1]: Leaving directory '/build/reproducible-path/ipip-1.1.13'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 255
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2