Subject: smartlist: ftbfs with GCC-15

From: Matthias Klose <[email-masked]>
Date: Mon, 17 Feb 2025 17:54:02 +0000

Package: src:smartlist
Version: 3.15-27
Severity: important
Tags: sid forky
User: [email-masked]
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/smartlist_3.15-27_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                              ^~~~~ ~~
_autotst.c:66:5: note: declared here
   66 | int close();
      |     ^~~~~
_autotst.c:167:24: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  167 |         signal(SIGTERM,Terminate);
      |                        ^~~~~~~~~
      |                        |
      |                        void (*)(void)
In file included from _autotst.c:10:
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
_autotst.c:72:6: note: ‘Terminate’ declared here
   72 | void Terminate()
      |      ^~~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
_autotst.c:177:33: error: too many arguments to function ‘close’; expected 0, have 1
  177 |            countlocks=MIN_locks;close(pip[1]);close(pipw[1]);
      |                                 ^~~~~ ~~~~~~
_autotst.c:66:5: note: declared here
   66 | int close();
      |     ^~~~~
_autotst.c:177:47: error: too many arguments to function ‘close’; expected 0, have 1
  177 |            countlocks=MIN_locks;close(pip[1]);close(pipw[1]);
      |                                               ^~~~~ ~~~~~~~
_autotst.c:66:5: note: declared here
   66 | int close();
      |     ^~~~~
_autotst.c:179:56: error: too many arguments to function ‘close’; expected 0, have 1
  179 |            timeout=0;sleep(1);read(pipw[0],&curflag,1);close(pipw[0]);
      |                                                        ^~~~~ ~~~~~~~
_autotst.c:66:5: note: declared here
   66 | int close();
      |     ^~~~~
_autotst.c:180:63: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  180 |            kill(ppid,SIGKILL);fdcollect=pip[0];signal(SIGALRM,stimeout);
      |                                                               ^~~~~~~~
      |                                                               |
      |                                                               void (*)(void)
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
_autotst.c:68:6: note: ‘stimeout’ declared here
   68 | void stimeout()
      |      ^~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
_autotst.c:191:21: error: too many arguments to function ‘close’; expected 0, have 1
  191 |            alarm(0);close(fdcollect);killchildren();
      |                     ^~~~~ ~~~~~~~~~
_autotst.c:66:5: note: declared here
   66 | int close();
      |     ^~~~~
make[4]: *** [Makefile:217: _autotst.o] Error 1
make[4]: Leaving directory '/build/reproducible-path/smartlist-3.15/src'
*******************************************************
I suggest you take a look at the definition of LDFLAGS*
in the Makefile before you try make again.
make[3]: *** [Makefile:119: ../autoconf.h] Error 1
make[3]: Leaving directory '/build/reproducible-path/smartlist-3.15/src'
make[2]: *** [Makefile:150: autoconf.h] Error 2
make[2]: Leaving directory '/build/reproducible-path/smartlist-3.15'
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/reproducible-path/smartlist-3.15'
make: *** [debian/rules:3: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2