Subject: tkdesk: ftbfs with GCC-15

From: Matthias Klose <[email-masked]>
Date: Mon, 17 Feb 2025 17:57:24 +0000

Package: src:tkdesk
Version: 2.0-12
Severity: important
Tags: sid forky
User: [email-masked]
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/tkdesk_2.0-12_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
  477 | static char ** ImgXpmGetDataFromId(interp, id)
      |                ^~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmGetDataFromString’:
tixImgXpm.c:498:16: warning: old-style function definition [-Wold-style-definition]
  498 | static char ** ImgXpmGetDataFromString(interp, string, numLines_return)
      |                ^~~~~~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmGetDataFromFile’:
tixImgXpm.c:627:16: warning: old-style function definition [-Wold-style-definition]
  627 | static char ** ImgXpmGetDataFromFile(interp, fileName, numLines_return)
      |                ^~~~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘GetType’:
tixImgXpm.c:685:15: warning: old-style function definition [-Wold-style-definition]
  685 | static char * GetType(colorDefn, type_ret)
      |               ^~~~~~~
tixImgXpm.c: In function ‘GetColor’:
tixImgXpm.c:732:15: warning: old-style function definition [-Wold-style-definition]
  732 | static char * GetColor(colorDefn, colorName, type_ret)
      |               ^~~~~~~~
tixImgXpm.c: In function ‘ImgXpmGetPixmapFromData’:
tixImgXpm.c:798:12: warning: old-style function definition [-Wold-style-definition]
  798 | static int ImgXpmGetPixmapFromData(interp, masterPtr, instancePtr)
      |            ^~~~~~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmConfigureInstance’:
tixImgXpm.c:1068:1: warning: old-style function definition [-Wold-style-definition]
 1068 | ImgXpmConfigureInstance(instancePtr)
      | ^~~~~~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmCmd’:
tixImgXpm.c:1145:1: warning: old-style function definition [-Wold-style-definition]
 1145 | ImgXpmCmd(clientData, interp, argc, argv)
      | ^~~~~~~~~
tixImgXpm.c:1156:9: warning: ‘result’ is deprecated: use Tcl_GetStringResult/Tcl_SetResult [-Wdeprecated-declarations]
 1156 |         sprintf(interp->result,
      |         ^~~~~~~
In file included from /usr/include/tcl8.6/tk.h:19,
                 from tixImgXpm.c:55:
/usr/include/tcl8.6/tcl.h:513:11: note: declared here
  513 |     char *result TCL_DEPRECATED_API("use Tcl_GetStringResult/Tcl_SetResult");
      |           ^~~~~~
tixImgXpm.c: In function ‘ImgXpmGet’:
tixImgXpm.c:1215:1: warning: old-style function definition [-Wold-style-definition]
 1215 | ImgXpmGet(tkwin, masterData)
      | ^~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmDisplay’:
tixImgXpm.c:1286:1: warning: old-style function definition [-Wold-style-definition]
 1286 | ImgXpmDisplay(clientData, display, drawable, imageX, imageY, width,
      | ^~~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmFree’:
tixImgXpm.c:1342:1: warning: old-style function definition [-Wold-style-definition]
 1342 | ImgXpmFree(clientData, display)
      | ^~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmDelete’:
tixImgXpm.c:1411:1: warning: old-style function definition [-Wold-style-definition]
 1411 | ImgXpmDelete(masterData)
      | ^~~~~~~~~~~~
tixImgXpm.c: In function ‘ImgXpmCmdDeletedProc’:
tixImgXpm.c:1449:1: warning: old-style function definition [-Wold-style-definition]
 1449 | ImgXpmCmdDeletedProc(clientData)
      | ^~~~~~~~~~~~~~~~~~~~
tixImgXpm.c: In function ‘Tix_DefinePixmap’:
tixImgXpm.c:1479:1: warning: old-style function definition [-Wold-style-definition]
 1479 | Tix_DefinePixmap(interp, name, data)
      | ^~~~~~~~~~~~~~~~
make[3]: Leaving directory '/build/reproducible-path/tkdesk-2.0/libdesk'
make[2]: *** [Makefile:160: lib_libdesk] Error 2
make[2]: Leaving directory '/build/reproducible-path/tkdesk-2.0'
dh_auto_build: error: make -j8 TKDESK_LIBRARY=/usr/lib/tkdesk returned exit code 2
make[1]: *** [debian/rules:17: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/tkdesk-2.0'
make: *** [debian/rules:11: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2