Debian Bug report logs - #319177
some patchs

Package: debconf; Maintainer for debconf is Debconf Developers <[email protected]>; Source for debconf is src:debconf (PTS, buildd, popcon).

Reported by: [email protected]

Date: Wed, 20 Jul 2005 10:48:02 UTC

Severity: normal

Full log


Message #15 received at [email protected] (full text, mbox, reply):

Received: (at 319177) by bugs.debian.org; 22 Jul 2005 08:53:00 +0000
From [email protected] Fri Jul 22 01:53:00 2005
Return-path: <[email protected]>
Received: from imag.imag.fr [129.88.30.1] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1DvtHA-00083w-00; Fri, 22 Jul 2005 01:53:00 -0700
Received: from localhost (trottinette.imag.fr [129.88.34.202])
	by imag.imag.fr (8.13.0/8.13.0) with ESMTP id j6M8quPd001166;
	Fri, 22 Jul 2005 10:52:56 +0200 (CEST)
Received: from 193.249.70.79 ( [193.249.70.79])
	as user [email protected] by webmail.imag.fr with HTTP;
	Fri, 22 Jul 2005 10:52:55 +0200
Message-ID: <[email protected]>
Date: Fri, 22 Jul 2005 10:52:56 +0200
From: [email protected]
To: Joey Hess <[email protected]>
Cc: [email protected]
Subject: Re: Bug#319177: some patchs
References: <[email protected]> <[email protected]>
In-Reply-To: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
User-Agent: Internet Messaging Program (IMP) 3.1
X-Originating-IP: 193.249.70.79
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (imag.imag.fr [129.88.30.1]); Fri, 22 Jul 2005 10:52:56 +0200 (CEST)
X-IMAG-MailScanner: Found to be clean
X-IMAG-MailScanner-Information: Please contact the ISP for more information
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by imag.imag.fr id j6M8quPd001166
Delivered-To: [email protected]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-4.4 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
	NO_REAL_NAME autolearn=no version=2.60-bugs.debian.org_2005_01_02
Surlignage Joey Hess <[email protected]>:

> >      - call Cache::shutdown in File::shutdown to synchronize data between
> >        cache and file.
> 
> I've applied the other patches, but it seems that this part of the patch
> has a bug. 
True

> I'm also interested to know whether you found an actual problem that
> your change above fixes.
> 
The problem is that all drivers use Cache::shutdown except File driver.
And after a shutdown, all items are not dirty except using File driver.

It is not a bug, but if we re-init the driver after a shutdown, there will be
items in dirty state but they should not be.

So if we don't use Cache:shutdown, we have to reset the dirty flag in
File::shutdown by adding this line in File.pm:

foreach my $item (sort keys %{$this->{cache}}) {
  next unless defined $this->{cache}->{item}; # skip deleted
  $this->{format}->write($fh, $this->{cache}->{$item}, item);
+ $this->{dirty}->{$item}=0 if defined $this->{dirty}->{$item};
}

and the unit tests will work ;) :
./test_debconf.pl Test::Debconf::DbDriver::FileTest
.....
OK (5 tests)




> -- 
> see shy jo
> 




-------------------------------------------------
envoyé via Webmail/IMAG !




Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Fri May 16 15:24:44 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.