Debian Bug report logs - #477092
grub-installer: does not support setting password for grub2

Full log

Message #29 received at [email protected] (full text, mbox, reply):

Received: (at 477092) by bugs.debian.org; 5 Sep 2009 08:14:41 +0000
From [email protected] Sat Sep 05 08:14:41 2009
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rietz.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 18; hammy, 148; neutral, 109; spammy,
	3. spammytokens:0.999-1--disastrous, 0.998-1--unqualified, 0.995-1--dle
	hammytokens:0.000-+--H*u:1.5.20, 0.000-+--H*UA:1.5.20,
	0.000-+--H*u:2009-06-14, 0.000-+--H*UA:2009-06-14, 0.000-+--H*c:protocol
X-Spam-Status: No, score=-8.3 required=4.0 tests=AWL,BAYES_00,FOURLA,
	FROMDEVELOPER,HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=ham
	version=3.2.3-bugs.debian.org_2005_01_02
Return-path: <[email protected]>
Received: from perrier.eu.org ([88.169.112.155] helo=kheops.perrier.eu.org)
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <[email protected]>)
	id 1MjqPw-0002U8-H4
	for [email protected]; Sat, 05 Sep 2009 08:14:41 +0000
Received: from localhost (localhost [127.0.0.1])
	by kheops.perrier.eu.org (Postfix) with ESMTP id 5FBC11C26E;
	Sat,  5 Sep 2009 10:14:36 +0200 (CEST)
Received: from kheops.perrier.eu.org ([127.0.0.1])
	by localhost (kheops.kheops.frmug.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id J9sXsgQrZD2A; Sat,  5 Sep 2009 10:14:36 +0200 (CEST)
Received: from mykerinos.kheops.frmug.org (mykerinos.kheops.frmug.org [192.168.1.3])
	by kheops.perrier.eu.org (Postfix) with ESMTP id 3F7641C21A;
	Sat,  5 Sep 2009 10:14:36 +0200 (CEST)
Received: by mykerinos.kheops.frmug.org (Postfix, from userid 1000)
	id C4F142284AA; Sat,  5 Sep 2009 10:14:33 +0200 (CEST)
Date: Sat, 5 Sep 2009 10:14:33 +0200
From: Christian Perrier <[email protected]>
To: Felix Zielcke <[email protected]>, [email protected]
Cc: Colin Watson <[email protected]>,
	[email protected]
Subject: Re: Bug#477092: [PATCH] add support for setting a username +
 password in grub-installer for GRUB 2
Message-ID: <[email protected]>
References: <[email protected]>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PMULwz+zIGJzpDN9"
Content-Disposition: inline
In-Reply-To: <[email protected]>
User-Agent: Mutt/1.5.20 (2009-06-14)

[Message part 1 (text/plain, inline)]

(CC'ing dle for templates review)

Quoting Felix Zielcke ([email protected]):

> Index: debian/grub-installer.templates
> ===================================================================
> --- debian/grub-installer.templates	(revision 60631)
> +++ debian/grub-installer.templates	(working copy)
> @@ -87,6 +87,32 @@ _Description: Device for boot loader ins
>      your third drive (SCSI here);
>    - "(fd0)" or "/dev/fd0" will install GRUB to a floppy.
>  
> +Template: grub-installer/superuser
> +Type: string
> +# :sl2:
> +_Description: GRUB superuser:
> + The GRUB boot loader offers many powerful interactive features, which could
> + be used to compromise your system if unauthorized users have access to the
> + machine when it is starting up. To defend against this, you may choose a
> + username and password which will be required before editing menu entries or
> + entering the GRUB command-line interface. By default, any user will still be
> + able to start any menu entry without entering a username and password.
> + .
> + If you do not wish to set a GRUB username, leave this field blank.
> +

"s/your system/the system"

maybe s/starting up/booting up"

I'm not sure about "To defend against this"

"username" or "user name"?


> +Template: grub-installer/grub2-password
> +Type: password
> +# :sl2:
> +_Description: GRUB password:
> + Please enter the password you want to use for GRUB 2.


I'd suggest something else than "you want to use".

Maybe "Please enter the GRUB 2 password."

We need to choose between "GRUB 2" and "GRUB". Probably drop the
"2". After all, this might be used in an hypothetical GRUB3, right? :-)

Another option is somethign similar to the root password prompt:

_Description: GRUB password:  
 You need to set a password for GRUB. A malicious or unqualified user
 with GRUB access can have disastrous results, so you should take care
 to choose a GRUB password that is not easy to guess. It should not be
 a word found in dictionaries, or a word that could be easily
 associated with you.

(that will help translators as fuzzy matching will prefill translations)

> +
> +Template: grub-installer/empty-password
> +Type: error
> +# :sl2:
> +_Description: Empty password
> + You have given a username but no password. If you don't want authorization
> + please don't specify an username, else you have to give a password.
> +

You may want to use the same wording than the similar template in
user-setup:

_Description: Empty password
 You entered an empty password, which is not allowed.
 Please choose a non-empty password.

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.