Debian Bug report logs - #531221
okular: Arbitrarily enforces DRM by default

version graph

Package: okular; Maintainer for okular is Debian Qt/KDE Maintainers <[email protected]>; Source for okular is src:okular (PTS, buildd, popcon).

Reported by: John Goerzen <[email protected]>

Date: Sun, 31 May 2009 00:12:04 UTC

Severity: wishlist

Tags: patch, wontfix

Found in version kdegraphics/4:4.2.2-2

Full log

🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#531221: okular: Arbitrarily enforces DRM
Reply-To: John Goerzen <[email protected]>, [email protected]
Resent-From: John Goerzen <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian Qt/KDE Maintainers <[email protected]>
Resent-Date: Sun, 31 May 2009 18:36:04 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 531221
X-Debian-PR-Package: okular
X-Debian-PR-Keywords: wontfix
X-Debian-PR-Source: kdegraphics
Received: via spool by [email protected] id=B531221.124379487828480
          (code B ref 531221); Sun, 31 May 2009 18:36:04 +0000
Received: (at 531221) by bugs.debian.org; 31 May 2009 18:34:38 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rietz.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 45; hammy, 144; neutral, 89; spammy,
	7. spammytokens:0.999-1--drops, 0.998-1--1487, 0.997-1--incredibly,
	0.987-1--accepting, 0.987-1--secondly hammytokens:0.000-+--H*u:20090103,
	0.000-+--H*UA:20090103, 0.000-+--HX-Enigmail-Version:0.95.0,
	0.000-+--H*u:sk:Mozilla, 0.000-+--UD:orig
X-Spam-Status: No, score=-8.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
	MURPHY_DRUGS_REL8,SPF_HELO_PASS,SPF_PASS,VALID_BTS_CONTROL autolearn=ham
	version=3.2.3-bugs.debian.org_2005_01_02
Received: from b01s02mr.corenetworks.net ([64.85.160.192] helo=glockenspiel.complete.org)
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <[email protected]>)
	id 1MAprh-0007ON-UB; Sun, 31 May 2009 18:34:38 +0000
Received: from 63-245-179-205.kitusa.com ([63.245.179.205] helo=erwin.lan.complete.org)
	by glockenspiel.complete.org with esmtps
	(with TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(TLS peer CN erwin.complete.org, certificate verified)
	(Exim 4.69)
	id 1MApre-0003f3-VK; Sun, 31 May 2009 13:34:35 -0500
Received: from katherina.lan.complete.org ([10.200.0.4])
	by erwin.lan.complete.org with esmtps
	(with TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(No TLS peer certificate)
	(Exim 4.69)
	id 1MAprb-0002BO-Uy; Sun, 31 May 2009 13:34:31 -0500
Received: from localhost ([127.0.0.1])
	by katherina.lan.complete.org with esmtp (Exim 4.69)
	(envelope-from <[email protected]>)
	id 1MAprb-0002DS-Q5; Sun, 31 May 2009 13:34:31 -0500
Message-ID: <[email protected]>
Date: Sun, 31 May 2009 13:34:31 -0500
From: John Goerzen <[email protected]>
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Sune Vuorela <[email protected]>
CC: [email protected], [email protected], 
 [email protected]
References: <[email protected]> <[email protected]> <[email protected]> <[email protected]>
In-Reply-To: <[email protected]>
X-Enigmail-Version: 0.95.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by Exiscan on glockenspiel.complete.org at Sun, 31 May 2009 13:34:35 -0500

tags 531221 patch
thanks

Sune Vuorela wrote:
>> 2) Patch the default to have it disabled
> 
> It's a deviation from upstream that we would have to maintain for eternity.
> This issue is not important enough for me to put the extra required work into 
> it

Here's the patch:

jgoerzen@katherina:/tmp/kdegraphics-4.2.2/okular/conf$ diff -d -u
okular.kcfg.orig okular.kcfg
--- okular.kcfg.orig    2009-05-31 13:27:25.310927480 -0500
+++ okular.kcfg 2009-05-31 13:27:32.258926063 -0500
@@ -148,7 +148,7 @@
  </group>
  <group name="General" >
   <entry key="ObeyDRM" type="Bool" >
-   <default>true</default>
+   <default>false</default>
   </entry>
   <entry key="ChooseGenerators" type="Bool" >
    <default>false</default>

I don't want to be a thorn in anybody's side here, but are you seriously
telling me that this 1-word patch is too much to maintain?  It's in a
default config file, not even in a .cpp or .h source file.

>> 3) Patch the prompt to have an "allow/deny" option
> 
> It's a deviation from upstream that we would have to maintain for eternity.
> This issue is not important enough for me to put the extra required work into 
> it.
> Getting the prompt options translated and patch all translation packages is 
> also not something to be easy done, please get out of your anglocentered 
> world.

I'm sure that there are i18n templates elsewhere in KDE with similar
language that could be copied.  It is rather fallacious of you to assume
I'm making an anglo-centric remark by suggesting a dialog be improved.
Right now it sucks for everyone.  It could be made better for everyone.

> When accepting patches that upstream won't carry the maintainers have to 
> maintain it forever, thru all new upstream revisions of the software. Some 
> times, it can be done with quilt refresh, some times it needs a much closer 
> look at the code to get to a good enough level of understanding to actually be 
> able to update the patch. 

First off, if upstream ever drops the patch, it is no worse than the
current situation.

Secondly, this is an incredibly trivial patch.  It is changing one word
"true" to "false" in a config file.  If only all the patches I had to
maintain were so simple!

-- John

Send a report that this bug log contains spam.

Debian bug tracking system administrator <[email protected]>. Last modified: Thu May 15 15:44:46 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.