Debian Bug report logs - #550010
hfsplus corrupts filesystems >2TB

version graph

Package: linux-image-2.6.26-1-amd64; Maintainer for linux-image-2.6.26-1-amd64 is (unknown);

Reported by: Marc Tamsky <[email protected]>

Date: Tue, 6 Oct 2009 23:36:02 UTC

Severity: critical

Found in version linux-2.6/2.6.26-13

Fixed in versions linux-2.6/2.6.31-1~experimental.2, linux-2.6/2.6.26-20

Done: dann frazier <[email protected]>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#550010: [PATCH] hfsplus: Refuse to mount volumes larger than 2TB
Reply-To: Ben Hutchings <[email protected]>, [email protected]
Resent-From: Ben Hutchings <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian Kernel Team <[email protected]>
X-Loop: [email protected]
Resent-Date: Sun, 11 Oct 2009 17:06:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 550010
X-Debian-PR-Package: linux-image-2.6.26-1-amd64
X-Debian-PR-Keywords: pending
X-Debian-PR-Source: linux-2.6
Received: via spool by [email protected] id=B550010.125528051213135
          (code B ref 550010); Sun, 11 Oct 2009 17:06:01 +0000
Received: (at 550010) by bugs.debian.org; 11 Oct 2009 17:01:52 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rietz.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 13; hammy, 138; neutral, 49; spammy,
	6. spammytokens:0.987-1--H*RU:sk:1Mx1nX-, 0.987-1--H*r:sk:1Mx1nX-,
	0.987-1--HX-Spam-Relays-External:sk:1Mx1nX-, 0.987-1--H*r:sk:1Mx1nW-,
	0.898-+--today hammytokens:0.000-+--H*c:protocol, 0.000-+--H*c:micalg,
	0.000-+--H*c:signed, 0.000-+--H*c:pgp-signature, 0.000-+--H*c:pgp-sha1
X-Spam-Status: No, score=-7.3 required=4.0 tests=AWL,BAYES_00,FOURLA,
	MURPHY_DRUGS_REL8,PGPSIGNATURE autolearn=ham
	version=3.2.3-bugs.debian.org_2005_01_02
Received: from shadbolt.e.decadent.org.uk ([88.96.1.126])
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <[email protected]>)
	id 1Mx1nr-0003PN-Qs
	for [email protected]; Sun, 11 Oct 2009 17:01:52 +0000
Received: from deadeye.i.decadent.org.uk ([192.168.4.185] helo=localhost)
	by shadbolt.decadent.org.uk with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69)
	(envelope-from <[email protected]>)
	id 1Mx1nX-0001Xn-Rn; Sun, 11 Oct 2009 18:01:32 +0100
Received: from womble by localhost with local (Exim 4.69)
	(envelope-from <[email protected]>)
	id 1Mx1nW-0005vq-U4; Sun, 11 Oct 2009 18:01:30 +0100
From: Ben Hutchings <[email protected]>
To: Andrew Morton <[email protected]>
Cc: [email protected], Eric Sesterhenn <[email protected]>, Roman Zippel <[email protected]>, [email protected]
In-Reply-To: <[email protected]>
References: <1254883878.4246.191.camel@localhost>
	 <1255227087.25061.76.camel@localhost>
	 <[email protected]>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Pe0GxBTT0Xu6zyb4WbZK"
Date: Sun, 11 Oct 2009 18:01:30 +0100
Message-Id: <1255280490.25061.280.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.0 
X-SA-Exim-Connect-IP: 192.168.4.185
X-SA-Exim-Mail-From: [email protected]
X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:14:11 +0000)
X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk)

[Message part 1 (text/plain, inline)]
On Sun, 2009-10-11 at 00:51 -0700, Andrew Morton wrote:
[...]
> > --- a/fs/hfsplus/wrapper.c
> > +++ b/fs/hfsplus/wrapper.c
> > @@ -99,6 +99,10 @@
> >  
> >  	if (hfsplus_get_last_session(sb, &part_start, &part_size))
> >  		return -EINVAL;
> > +	if (part_start + part_size > 0x100000000) {
> > +		pr_err("hfs: volumes larger than 2TB are not supported yet\n");
> > +		return -EINVAL;
> > +	}
> 
> part_start and part_size are sector_t.  This code will do weird overflow
> things when sector_t is 32-bit.

Sorry, I forgot CONFIG_LBD is still optional.

> Also 32-bit compilers will get upset at the excessively large hex constant.
[...]

Good point.

Ben.

-- 
Ben Hutchings
DNRC Motto:  I can please only one person per day.
Today is not your day.  Tomorrow isn't looking good either.

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

Debian bug tracking system administrator <[email protected]>. Last modified: Fri May 9 21:38:52 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.