Debian Bug report logs - #612863
[dget] Compare timestamps before downloading

Reply or subscribe to this bug.

Display info messages

Message #5 received at [email protected] (full text, mbox, reply):

From: Aníbal Monsalve Salazar <[email protected]>

To: [email protected]

Subject: devscripts: please preserve timestamps in the dget script

Date: Fri, 11 Feb 2011 08:03:40 +0000

Package: devscripts
Version: 2.10.69
Tags: patch

Please preserve timestamps in the dget script. I'm using the patch
below to pass the -N option to wget. I don't know the corresponding
option for curl.

--- /usr/bin/dget~	2010-10-21 23:05:30.000000000 +1100
+++ /usr/bin/dget	2011-02-11 18:56:04.000000000 +1100
@@ -115,6 +115,7 @@ sub wget {
     # curl does not follow document moved headers, and does not exit
     # with a non-zero error code by default if a document is not found
     push @cmd, "-f", "-L" if $wget eq "curl";
+    push @cmd, "-N" if $wget eq "wget";
     push @cmd, ($wget eq "wget" ? "-nv" : ("-s", "-S")) if $opt->{'quiet'};
     push @cmd, ($wget eq "wget" ? "--no-check-certificate" : "--insecure") if $opt->{'insecure'};
     push @cmd, ($wget eq "wget" ? "--no-cache" : ("--header", "Pragma: no-cache")) if $opt->{'no-cache'};

Message #10 received at [email protected] (full text, mbox, reply):

From: James Vega <[email protected]>

To: Aníbal Monsalve Salazar <[email protected]>, [email protected]

Subject: Re: Bug#612863: devscripts: please preserve timestamps in the dget script

Date: Mon, 14 Feb 2011 23:57:07 -0500

[Message part 1 (text/plain, inline)]

On Fri, Feb 11, 2011 at 08:03:40AM +0000, Aníbal Monsalve Salazar wrote:
> Please preserve timestamps in the dget script. I'm using the patch
> below to pass the -N option to wget. I don't know the corresponding
> option for curl.

What use is this in the context of dget?  If you've already downloaded a
file, dget won't download it again unless the existing file doesn't
match the hash in the dsc.  Plus, filenames are versioned so there isn't
an expectation that a file with the same name may be updated in the
future.  Also, your patch doesn't change the current behavior at all
since wget ignores -N when -O is being used (which dget does).

-- 
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <[email protected]>

[signature.asc (application/pgp-signature, inline)]

Message #19 received at [email protected] (full text, mbox, reply):

From: Christoph Biedl <[email protected]>

To: James Vega <[email protected]>

Cc: Aníbal Monsalve Salazar <[email protected]>, [email protected]

Subject: Re: Bug#612863: devscripts: please preserve timestamps in the dget script

Date: Mon, 17 Sep 2012 12:23:56 +0200

James Vega wrote...

> On Fri, Feb 11, 2011 at 08:03:40AM +0000, Aníbal Monsalve Salazar wrote:
> > Please preserve timestamps in the dget script. I'm using the patch
> > below to pass the -N option to wget. I don't know the corresponding
> > option for curl.
> 
> What use is this in the context of dget?

Call it compability with apt-get source which does preserve the
timestamps.

Or just eye-candy.

Or, although rather personal: An .orig.tar.gz with a timestamp of more
or less "now" is an alarm sign to me: In the past I saw that only if
that tar ball was re-generated, something that was very likely not
intended.

> Also, your patch doesn't change the current behavior at all
> since wget ignores -N when -O is being used (which dget does).

Indeed, dget using wget always worked as expected here, read:
timestamps were preserved. Aníbal, I suspect you have an .wgetrc
interfering, causing you to suggest "-N".

The trouble for me started when curl was installed and preferred by
dget, since the "-R" (long form is better: "--remote-time") option is
needed for curl. I'm not including the trivial patch, however it works
for me.

    Christoph

Message #24 received at [email protected] (full text, mbox, reply):

From: Christoph Biedl <[email protected]>

To: [email protected]

Subject: Re: Bug#612863: devscripts: please preserve timestamps in the dget script

Date: Wed, 19 Apr 2023 10:29:41 +0200

[Message part 1 (text/plain, inline)]

Christoph Biedl wrote...

> James Vega wrote...
> 
> > On Fri, Feb 11, 2011 at 08:03:40AM +0000, Aníbal Monsalve Salazar wrote:
> > > Please preserve timestamps in the dget script. I'm using the patch
> > > below to pass the -N option to wget. I don't know the corresponding
> > > option for curl.
> > 
> > What use is this in the context of dget?
> 
> Call it compability with apt-get source which does preserve the
> timestamps.
> 
> Or just eye-candy.
> 
> Or, although rather personal: An .orig.tar.gz with a timestamp of more
> or less "now" is an alarm sign to me: In the past I saw that only if
> that tar ball was re-generated, something that was very likely not
> intended.
> 
> > Also, your patch doesn't change the current behavior at all
> > since wget ignores -N when -O is being used (which dget does).
> 
> Indeed, dget using wget always worked as expected here, read:
> timestamps were preserved. Aníbal, I suspect you have an .wgetrc
> interfering, causing you to suggest "-N".
> 
> The trouble for me started when curl was installed and preferred by
> dget, since the "-R" (long form is better: "--remote-time") option is
> needed for curl. I'm not including the trivial patch, however it works
> for me.

Seems this was resolved in 2.23.0 after the request came up again in
#1020914

    Christoph

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.