Debian Bug report logs - #613046
debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

Full log

Message #15 received at [email protected] (full text, mbox, reply):

Received: (at 613046) by bugs.debian.org; 12 Feb 2011 22:41:12 +0000
From [email protected] Sat Feb 12 22:41:11 2011
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on busoni.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 68; hammy, 151; neutral, 111; spammy,
	0. spammytokens: hammytokens:0.000-+--v1410, 0.000-+--v1.4.10,
	0.000-+--sk:dpkgbu, 0.000-+--sk:dpkg-bu, 0.000-+--sk:iqicbae
X-Spam-Status: No, score=-9.2 required=4.0 tests=BAYES_00,FVGT_m_MULTI_ODD,
	HAS_BUG_NUMBER,IMPRONONCABLE_2,MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2,
	PGPSIGNATURE,URIBL_CNKR autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Return-path: <[email protected]>
Received: from csmtp3.one.com ([91.198.169.23])
	by busoni.debian.org with esmtp (Exim 4.69)
	(envelope-from <[email protected]>)
	id 1PoO9B-0004Dj-Ci
	for [email protected]; Sat, 12 Feb 2011 22:41:11 +0000
Received: from [82.211.215.77] (unknown [82.211.215.77])
	by csmtp3.one.com (Postfix) with ESMTP id CC148240563E
	for <[email protected]>; Sat, 12 Feb 2011 22:40:48 +0000 (UTC)
Message-ID: <[email protected]>
Date: Sat, 12 Feb 2011 23:38:46 +0100
From: Niels Thykier <[email protected]>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101227 Icedove/3.0.11
MIME-Version: 1.0
To: [email protected]
Subject: Re: Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules
 and DEB_BUILD_OPTIONS)
References: <[email protected]> <[email protected]>
In-Reply-To: <[email protected]>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-02-12 22:32, Julien Cristau wrote:
> On Sat, Feb 12, 2011 at 14:25:40 +0100, Niels Thykier wrote:
> 
>> Package: debian-policy
>> Version: 3.9.1.0
>> Severity: minor
>>
>> Hey
>>
>> The example in 4.9.1 suggests to set CFLAGS in a way that completely
>> overrides values from dpkg-buildpackage/dpkg-buildflags[1]:
>>
>> CFLAGS = -Wall -g
>>
>> This will set CFLAGS to "-Wall -g" regardless of what dpkg-buildflags
>> provides.  Possible alternatives that appears to work are:
>>
>> CFLAGS := $(CFLAGS) -Wall -g
>>
> That would be wrong.  A package build shouldn't depend on random env
> variables.
> 

I believe a lot of packages in the archive actually suffers from this
issue then, if dpkg-build{package,flags} did not sanitize these variables.
  How many packages explicitly sets e.g. LDFLAGS in debian/rules? Almost
none of mine does it (granted most of my packages are Java packages, but
still).

>> CFLAGS  = $(shell dpkg-buildflags --get CFLAGS) -Wall -g
>>
>> While related to #578597, I believe it to be a distinct issue. This was triggered
>> by this email[2] on debian-mentors.
>>
> Seems to be the exact same request to me?
> 
> Cheers,
> Julien
> 

Well, yes, if you insist the "CFLAGS  := $(CFLAGS) somearg" is wrong, it
would appear that my original request can be trivially be reduced to
#578597.
  Though in that case, I think we should change this one to a request to
make the policy be explicit in how a package should handle variables
from the environment (and which variables it should neutralize).

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNVwv1AAoJEAVLu599gGRC3twQAIfvAyQRXBN51/aMMDxb3Zyk
dSKdi9OnebvufSULxvgWZJ0pm8+QUp/pjg1FAELGo4tbmFv6jqbW8KIhws3UACtP
TZ9ohwnt/9Hdp3Whvu2gPze0CvKSkplYLtrAMpevvi4S6RN5qX/Un0QtyeD1oNfn
47nJcPINryWZPKKWI6boq1EGed3m2+CIzzjvKtPeQHX/40rgwN39kAZpiuBNGah/
3TiM1/ETZl7oXXxCpJ8EzN62CA3vj6ugSBVCfLFVjlv82sMTV8mZTYaBK2Re8BSu
MHWzb7PHButf3J2xwL1RoaoeuwnJEs+mgP8oFeprf5T4ugjwMbN/FmcxTm2DQlt8
ZbnRFiuBIO/D30TtiW3DAsUcOhZasIcvtRuNZ1U1LFkXj79n4fHsBYIrTdEnbbtR
27lGITVVAHfscZsReIn8Eb3V1uJgklVnQeyMZSpb8wSaKoEVv9uLZPc/NCV9KC41
PahhxuEkTMQfFwCY6cxaeHq/nZwY1XWUYGmHioa0/cPDARyIbwNU2nC6qZNxGCuQ
C5NONW+cTDIqu1S7Hh07B+oRA6MIW8iLZUUdt0kxv0L0ZTawJRk3Kgu7AYPl66CN
cI/n4fNPsAEcPHnMYfk+L+xduO89krrlu38eGAX2a5Z15ZKlaV2NDHlermErcfgg
jsSQKFlYiDiAkjS8hfix
=zUym
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.