Subject: libtest-critic-perl: Mixed bool operators false positive on postfix control

From: Guillem Jover <[email-masked]>
Date: Fri, 11 Jan 2013 13:00:42 +0100

Package: libperl-critic-perl
Version: 1.118-1
Severity: normal
Tags: upstream

Hi!

Here's what seems like a false positive that I found while going over
the dpkg code:

,--- mixed-bool.pl
#!/usr/bin/perl

use strict;
use warnings;

our $VERSION = '0.0';

my $value = 0;

$value ||= 1 if 1 and 1;

1;
`---

Reproducible with:

  $ perlcritic -s ProhibitMixedBooleanOperators mixed-bool.pl

Thanks,
Guillem