Debian Bug report logs - #706303
libperl-critic-perl: until block false-positive in hash key

Reply or subscribe to this bug.

Display info messages

Message #5 received at [email protected] (full text, mbox, reply):

From: Guillem Jover <[email protected]>

To: [email protected]

Subject: libperl-critic-perl: until block false-positive in hash key

Date: Sun, 28 Apr 2013 01:29:55 +0200

Package: libperl-critic-perl
Version: 1.118-1
Severity: normal

Hi!

I found the following false-positive while going through the dpkg code
base:

,--- until.pl ---
#!/usr/bin/perl

use strict;
use warnings;

our $VERSION = '0.00';

my %hash;

$hash{since}   = 0;
$hash{until}   = 1;
$hash{'until'} = 0;
`---

which gives:

  $ perlcritic --verbose 1 -1 until.pl
  until.pl:11:7:"until" block used

Thanks,
Guillem

Message #12 received at [email protected] (full text, mbox, reply):

From: Guillem Jover <[email protected]>

To: [email protected]

Subject: Re: Bug#706303: libperl-critic-perl: until block false-positive in hash key

Date: Tue, 30 Apr 2013 15:21:53 +0200

Hi!

On Sun, 2013-04-28 at 01:29:55 +0200, Guillem Jover wrote:
> Package: libperl-critic-perl
> Version: 1.118-1
> Severity: normal
> 
> I found the following false-positive while going through the dpkg code
> base:
> 
> ,--- until.pl ---
> #!/usr/bin/perl
> 
> use strict;
> use warnings;
> 
> our $VERSION = '0.00';
> 
> my %hash;
> 
> $hash{since}   = 0;
> $hash{until}   = 1;
> $hash{'until'} = 0;
> `---
> 
> which gives:
> 
>   $ perlcritic --verbose 1 -1 until.pl
>   until.pl:11:7:"until" block used

Actually, I missed an older instance that I had already marked to not
be criticized, here's the updated test case:

,--- until.pl ---
#!/usr/bin/perl

use strict;
use warnings;

our $VERSION = '0.00';

my %hash;
$hash{since}   = 0;
$hash{until}   = 1;
$hash{'until'} = 0;

sub func { }
func( { since   => 0, until => 1 } );
func( { until   => 1, since => 0 } );
func( { 'until' => 1, since => 0 } );
`---

And the violations:

  $ perlcritic --verbose 1 -1 until.pl
  until.pl:10:7:"until" block used
  until.pl:15:9:"until" block used

Thanks,
Guillem

Message #17 received at [email protected] (full text, mbox, reply):

From: Salvatore Bonaccorso <[email protected]>

To: Guillem Jover <[email protected]>, [email protected]

Subject: Re: Bug#706303: libperl-critic-perl: until block false-positive in hash key

Date: Thu, 2 May 2013 21:52:13 +0200

Hi Guillem

On Tue, Apr 30, 2013 at 03:21:53PM +0200, Guillem Jover wrote:
> Hi!
> 
> On Sun, 2013-04-28 at 01:29:55 +0200, Guillem Jover wrote:
> > Package: libperl-critic-perl
> > Version: 1.118-1
> > Severity: normal
> > 
> > I found the following false-positive while going through the dpkg code
> > base:
> > 
> > ,--- until.pl ---
> > #!/usr/bin/perl
> > 
> > use strict;
> > use warnings;
> > 
> > our $VERSION = '0.00';
> > 
> > my %hash;
> > 
> > $hash{since}   = 0;
> > $hash{until}   = 1;
> > $hash{'until'} = 0;
> > `---
> > 
> > which gives:
> > 
> >   $ perlcritic --verbose 1 -1 until.pl
> >   until.pl:11:7:"until" block used
> 
> Actually, I missed an older instance that I had already marked to not
> be criticized, here's the updated test case:

Thanks! Updated upstream bugtracker information.

Regards,
Salvatore

Send a report that this bug log contains spam.