Debian Bug report logs - #831521
[uscan] add support to run custom mk-origtargz

Full log

Message #74 received at [email protected] (full text, mbox, reply):

Received: (at 831521) by bugs.debian.org; 31 Aug 2017 00:10:54 +0000
From [email protected] Thu Aug 31 00:10:54 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1-bugs.debian.org_2005_01_02
	(2015-04-28) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.6 required=4.0 tests=DIGITS_LETTERS,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HAS_BUG_NUMBER,PGPSIGNATURE,RP_MATCHES_RCVD,SPF_PASS,
	URIBL_CNKR autolearn=unavailable autolearn_force=no
	version=3.4.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.5  spammytokens: hammytokens:
Return-path: <[email protected]>
Received: from kwanyin.sergiodj.net ([158.69.185.54])
	by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <[email protected]>)
	id 1dnD4P-0000ZI-P0
	for [email protected]; Thu, 31 Aug 2017 00:10:54 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=sergiodj.net; s=20160602; h=Content-Type:MIME-Version:Message-ID:
	In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
	List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	 bh=askjHE+BAWrgPtlZRLbsJXvPmD5XRUc+lRqZHJRVw7E=; b=k+Eu1nD48vXQhtlJ7N55gsHkH
	TDf7/4sYl0TbaZp/sidF30drcW/ZKoc/PsHLSx8VVk02cnSK6rku1xNgVvfg6K8cL6W/vo2+PKaJa
	cQFqUWJocaQpNyM2Y/dvneNGuThnALZUhQC92RXodANATWs+ZQgySbflTJC26iDscOmGQ=;
From: Sergio Durigan Junior <[email protected]>
To: Osamu Aoki <[email protected]>
Cc: [email protected],  Christopher Hoskin <[email protected]>
Subject: Re: Bug#831521: Custom repacking
References: <[email protected]>
	<[email protected]> <[email protected]>
	<[email protected]>
X-URL: http://blog.sergiodj.net
Date: Wed, 30 Aug 2017 20:10:50 -0400
In-Reply-To: <[email protected]> (Osamu Aoki's
	message of "Mon, 28 Aug 2017 23:12:56 +0900")
Message-ID: <[email protected]>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

[Message part 1 (text/plain, inline)]

On Monday, August 28 2017, Osamu Aoki wrote:

>> diff --git a/scripts/uscan.pl b/scripts/uscan.pl
>> index f871daf2..49a7acb2 100755
>> --- a/scripts/uscan.pl
>> +++ b/scripts/uscan.pl
>> @@ -60,8 +60,9 @@ than the last upstream version.
>>  =item * B<uscan> saves the downloaded tarball to the parent B<../> directory:
>>  I<< ../<upkg>-<uversion>.tar.gz >>
>>  
>> -=item * B<uscan> invokes B<mk-origtargz> to create the source tarball: I<<
>> -../<spkg>_<oversion>.orig.tar.gz >>
>> +=item * B<uscan> invokes B<mk-origtargz> to create the source tarball:
>> +I<< ../<spkg>_<oversion>.orig.tar.gz >> (if F<debian/mk-origtargz>
>> +exists and is executable, then execute it instead).
>>  
>>  =over
>>  
>> @@ -706,7 +707,8 @@ doesn't work.
>>  
>>  B<uscan> invokes B<mk-origtargz> to create the source tarball properly named
>>  for the source package with B<.orig.> (or B<< .orig-<component>. >> for the
>> -secondary tarballs) in its filename.
>> +secondary tarballs) in its filename.  If F<debian/mk-origtargz> exists and is
>> +executable, then B<uscan> invokes it instead.
>>  
>>  =over
>>  
>> @@ -3764,7 +3766,15 @@ EOF
>>      my $path = "$destdir/$newfile_base";
>>      my $target = $newfile_base;
>>      unless ($symlink eq "no") {
>> -	my @cmd = ("mk-origtargz");
>> +	my @cmd = ();
>> +	if (-x 'debian/mk-origtargz') {
>> +	    # If the user has specified a personalized 'mk-origtargz'
>> +	    # under debian/, we use it instead of the system script.
>> +	    push @cmd "debian/mk-origtargz";
>> +	    uscan_verbose "Using debian/mk-origtargz instead of mk-origtargz\n";
>> +	} else {
>> +	    push @cmd "mk-origtargz";
>> +	}
>>  	push @cmd, "--package", $pkg;
>>  	push @cmd, "--version", $common_mangled_newversion;
>>  	push @cmd, '--repack-suffix', $options{repacksuffix} if defined $options{repacksuffix};
>
> Yes, this is what I am talking about.  Maybe, we should add
> F<debian/uupdate> in the same way. 
>
> Adding these features are easy but let's go slow.  Once we add any
> features, we can't remove them easily.  Let's wait and check if there
> are no objection or second thought.

Yeah, adding debian/update can be done later, prefereably in another bug
I think :-).

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.