Debian Bug report logs - #832687
support uefi

Package: open-infrastructure-system-build; Maintainer for open-infrastructure-system-build is Daniel Baumann <[email protected]>; Source for open-infrastructure-system-build is src:open-infrastructure-system-tools (PTS, buildd, popcon).

Reported by: Raphaël Hertzog <[email protected]>

Date: Mon, 18 Nov 2013 09:33:02 UTC

Severity: wishlist

Full log

Message #303 received at [email protected] (full text, mbox, reply):

Received: (at 731709) by bugs.debian.org; 21 Mar 2016 21:20:06 +0000
From [email protected] Mon Mar 21 21:20:05 2016
X-Spam-Checker-Version: SpamAssassin 3.4.0-bugs.debian.org_2005_01_02
	(2014-02-07) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FOURLA,FREEMAIL_FROM,HAS_BUG_NUMBER,
	MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_CNKR autolearn=ham
	autolearn_force=no version=3.4.0-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 40; hammy, 149; neutral, 76; spammy,
	1. spammytokens:0.914-+--limited
	hammytokens:0.000-+--HX-Google-DKIM-Signature:in-reply-to,
	0.000-+--HX-Google-DKIM-Signature:references, 0.000-+--livebuild,
	0.000-+--live-build, 0.000-+--grubefi
Return-path: <[email protected]>
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f])
	by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1ai7F7-0005H2-OQ
	for [email protected]; Mon, 21 Mar 2016 21:20:05 +0000
Received: by mail-wm0-x22f.google.com with SMTP id p65so138404615wmp.0
        for <[email protected]>; Mon, 21 Mar 2016 14:20:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=M5BapLLkQo2yfaeA660lfueHp+yPJN7oO8l/J+7v+S4=;
        b=U9ihdatYmLpcKfU6q9a/pCYfJwuowW9z6IeClKEAPhKdAa0VHfhD8l7P/m14e6l4tQ
         3U0sIf7RFSab5H14PuqUDmF1asxYS8Cxo4vc5tUg/3b6+utJHe+bGn+m81BS/QuHiw4Z
         HIvNHL9aLGhINzbIXjfkG1CxEfps1pC38ZxlM34mL8x0W95A0txQ5n/SeRhiHnhlSOKI
         cVvbIAO/1rbqOcUuqKSyoh2F11a5vkL3pj8hBd97RZJhac/chdeN9JbI8OvGC9+ZCLGp
         5CDHY3vP3us6WxIbKdBkG2QhlWMYt10pHHzIh0JUVuZ0ER0NPHq8T0K7yjXgTQW62TYH
         TrHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=M5BapLLkQo2yfaeA660lfueHp+yPJN7oO8l/J+7v+S4=;
        b=ECkqYmQBvLTDaaMsFNt0JpVVE/4bPMKWq8SR/JHk19CsZzgawR5OHB1i5h+E5ykIhT
         OHGPwNH7hkmt02cbh2fBvjrlKegnONhx+0sdri88jP/wc5zAMKukkXIzT9Y18K1Yrrjl
         yqPPMWNTNUXqeHej/0g9SOo6k8626F0RZ/MvhXJl/3+V08h5RgfiKMjXXOPTNrMb35jr
         4hdPdfOJVvT44OHNYzU74/M+rRKJDm3IHYg+5TxqtGTJ7K+qgzh/ePHRi/5OcmNO2Bss
         5XXPaI6jV4cM+rzlLyvvzlms4XGQZV5JV1nQRbgLi+g/cONkk00VY7jm7J8/7R45rFLw
         sJRQ==
X-Gm-Message-State: AD7BkJLta4tayidg48VSJ9MD2Ue2m2v5V7ZaxzeB4GcEq3ARefXPWMl3ZpZERRhkmJeQXLdzWOpSlBeiW0XkgA==
X-Received: by 10.194.2.76 with SMTP id 12mr32919261wjs.28.1458595198496; Mon,
 21 Mar 2016 14:19:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.194.138.167 with HTTP; Mon, 21 Mar 2016 14:19:19 -0700 (PDT)
In-Reply-To: <[email protected]>
References: <[email protected]> <[email protected]>
 <[email protected]> <CAOMqctSbV_3SKbQ--cvAoFxwhHQckhhELmGpMW5_xkxAEY2W+Q@mail.gmail.com>
 <[email protected]> <CAOMqctSProNGUNJ106QQi9rDUsFzrEpU+FCo0z9aaHpNRYoHWg@mail.gmail.com>
 <[email protected]> <CAOMqctTRZMEzF5qwVp97+yyazBY8uhq6RSXXZ5YeBoYNF2qKNg@mail.gmail.com>
 <[email protected]> <CAOMqctTK6krSjinvEd9Fdo8RuRxriMBS=c1D-LdrWdfSX1KEkA@mail.gmail.com>
 <[email protected]>
From: Michal Suchanek <[email protected]>
Date: Mon, 21 Mar 2016 22:19:19 +0100
Message-ID: <CAOMqctSGq+4JKi5ESdP58FLB+36rM4=R3hkoe792VrGiv8Divw@mail.gmail.com>
Subject: Re: Bug#731709: grub-efi UEFI support based on debian-cd work
 complete (repos)
To: adrian15 <[email protected]>
Cc: Thomas Schmitt <[email protected]>, [email protected], 
	Raphaël Hertzog <[email protected]>, 
	jnq nfe <[email protected]>, Gaudenz Steinlin <[email protected]>, hhh orb <[email protected]>
Content-Type: text/plain; charset=UTF-8

Hello,

On 21 March 2016 at 21:09, adrian15 <[email protected]> wrote:

>
> The branch which include specifically the commits I attach here as patches
> is:
>
> https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5
>
> .
>
> About the variable names issue: I think the new terms: first and extra are
> ok because they are not implying some sort of rank while explaining what's
> the difference between them. Also, notice, that these are internal variables
> which final user of live-build does not see. I think we should focus on
> other aspects of my patch if there are more problems for it.

The problem is not with the name of the variable.

The problem is that you use it at all. In most places when you check
for primary or secondary bootloader you should just loop all
bootloaders and check each. In fact, in the previous batch of patches
I found no place where checking for primary or secondary bootloader
made any sense.

>
> If you think that the way bootloaders is currently managed by live-build is
> wrong please file up a new bug and send there your patch with your
> improvements so that it's get discussed.

The bootloader support in live-build is limited. With your patches it
becomes wrong. eg. compatibility of bootloader with selected
filesystem and image type is only checked for first bootloader and EFI
support is added only when grub-efi extra bootloader but not when it
is the first bootloader.

This is not fixed by renaming the variables.

Thanks

Michal

Send a report that this bug log contains spam.

Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 08:47:18 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.