Debian Bug report logs - #832687
support uefi

Package: open-infrastructure-system-build; Maintainer for open-infrastructure-system-build is Daniel Baumann <[email protected]>; Source for open-infrastructure-system-build is src:open-infrastructure-system-tools (PTS, buildd, popcon).

Reported by: Raphaël Hertzog <[email protected]>

Date: Mon, 18 Nov 2013 09:33:02 UTC

Severity: wishlist

Full log

🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
Reply-To: adrian15 <[email protected]>, [email protected]
Resent-From: adrian15 <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian QA Group <[email protected]>
X-Loop: [email protected]
Resent-Date: Tue, 22 Mar 2016 01:57:02 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 731709
X-Debian-PR-Package: live-build
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: live-build
Received: via spool by [email protected] id=B731709.145861169815322
          (code B ref 731709); Tue, 22 Mar 2016 01:57:02 +0000
Received: (at 731709) by bugs.debian.org; 22 Mar 2016 01:54:58 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.0-bugs.debian.org_2005_01_02
	(2014-02-07) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.3 required=4.0 tests=BAYES_00,DIGITS_LETTERS,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FOURLA,FREEMAIL_FROM,HAS_BUG_NUMBER,
	MIXEDBDN,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_CNKR,
	WEIRD_QUOTING autolearn=no autolearn_force=no
	version=3.4.0-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 86; hammy, 150; neutral, 1324; spammy,
	0. spammytokens: hammytokens:0.000-+--netboot, 0.000-+--grubcommon,
	0.000-+--grub-common, 0.000-+--H*u:31.8.0, 0.000-+--H*UA:31.8.0
Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230])
	by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1aiBX7-0003yh-Ss
	for [email protected]; Tue, 22 Mar 2016 01:54:58 +0000
Received: by mail-wm0-x230.google.com with SMTP id p65so173204896wmp.1
        for <[email protected]>; Mon, 21 Mar 2016 18:54:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to;
        bh=XeJVd4KKKcDCT1hAP+sxrz+IscSYWeQOpIM5wiBlZNs=;
        b=BYBnDoAKiNMr9jt93u89YfNe0jqG0rl092xd3V0s/rnLq0g1E5Q5JJ4qvhpkmESWpP
         eJHVikVluUmzSFf68MvPesGNoopiTf8a9qDhTgBl23A1nibLgYiNjg8jnAll5vQLvaSc
         P4cISEFCEnQmjLCzl+n6Z16Gp5YaRZDoH4lBn/xNe/CYPzAAkyktehs6r2mOQ/PlrSQg
         tkZOrIYP1diCatTNLNKMNp73ZYkUC1brOdwnjAdLbMiascaXuTbX1WPrMQSDZQ82u+BF
         RRFj3Q6qcovLrY7wqwe7cWIZKvTvWdEzNS2de3DGOej/NSYGogZwbR5IT7il8Xf8y8NT
         PKjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
         :cc:subject:references:in-reply-to;
        bh=XeJVd4KKKcDCT1hAP+sxrz+IscSYWeQOpIM5wiBlZNs=;
        b=lqNJ8gfiOyB5hUxNszL64PI2F63PGmb/Dca2b623Cc5gYHl+Apk55sON3vnmgB0l3u
         kjSttq/uqf7e1l+AI47p5HlJ4fCOh84H2TIenx7m3UOVJW3M59OCL+MNFU4T6zAn0wIK
         9Y2yP0bAbKq9IVUkMq6gd3pmWQyBscrwfABoEdL0tLczp+MEdr+yhN/y6i0QXuMgNx9Y
         xffLRyeBwgv6P3Tk8jxPS1pT1DmWZutMkJrYqCAyVpYNPDE8wo3WGb7GkkhLmeVkiYGA
         2Cyhvgyzr9/+BJXSjr1hyyJohGNhqfZsdTVWUfP3ezf2lnL4X8Vb/jUzwEkmtISeA0o+
         qR3w==
X-Gm-Message-State: AD7BkJIK6BpgrvkO623Nz9GgBuBTR9KQnfxvXoldwU8uJzDeK0DPgu+MDOqgO6rOTrhN7w==
X-Received: by 10.194.76.161 with SMTP id l1mr33150178wjw.108.1458611691216;
        Mon, 21 Mar 2016 18:54:51 -0700 (PDT)
Received: from [192.168.10.45] (73.Red-83-49-243.dynamicIP.rima-tde.net. [83.49.243.73])
        by smtp.gmail.com with ESMTPSA id g203sm14885869wmf.23.2016.03.21.18.54.48
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Mon, 21 Mar 2016 18:54:50 -0700 (PDT)
Message-ID: <[email protected]>
Date: Tue, 22 Mar 2016 02:54:46 +0100
From: adrian15 <[email protected]>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: Michal Suchanek <[email protected]>
CC: Thomas Schmitt <[email protected]>, [email protected], 
 Raphaël Hertzog <[email protected]>, 
 jnq nfe <[email protected]>,
 Gaudenz Steinlin <[email protected]>, hhh orb <[email protected]>
References: <[email protected]> <[email protected]> <[email protected]> <CAOMqctSbV_3SKbQ--cvAoFxwhHQckhhELmGpMW5_xkxAEY2W+Q@mail.gmail.com> <[email protected]> <CAOMqctSProNGUNJ106QQi9rDUsFzrEpU+FCo0z9aaHpNRYoHWg@mail.gmail.com> <[email protected]> <CAOMqctTRZMEzF5qwVp97+yyazBY8uhq6RSXXZ5YeBoYNF2qKNg@mail.gmail.com> <[email protected]> <CAOMqctTK6krSjinvEd9Fdo8RuRxriMBS=c1D-LdrWdfSX1KEkA@mail.gmail.com> <[email protected]> <CAOMqctSGq+4JKi5ESdP58FLB+36rM4=R3hkoe792VrGiv8Divw@mail.gmail.com>
In-Reply-To: <CAOMqctSGq+4JKi5ESdP58FLB+36rM4=R3hkoe792VrGiv8Divw@mail.gmail.com>
Content-Type: multipart/mixed;
 boundary="------------030001080309060804030804"

[Message part 1 (text/plain, inline)]
El 21/03/16 a las 22:19, Michal Suchanek escribió:
> Hello,
>
> On 21 March 2016 at 21:09, adrian15 <[email protected]> wrote:
>
>>
>> The branch which include specifically the commits I attach here as patches
>> is:
>>
>> https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5
>>
>> .
>>
>> About the variable names issue: I think the new terms: first and extra are
>> ok because they are not implying some sort of rank while explaining what's
>> the difference between them. Also, notice, that these are internal variables
>> which final user of live-build does not see. I think we should focus on
>> other aspects of my patch if there are more problems for it.
>
> The problem is not with the name of the variable.
>
> The problem is that you use it at all. In most places when you check
> for primary or secondary bootloader you should just loop all
> bootloaders and check each. In fact, in the previous batch of patches
> I found no place where checking for primary or secondary bootloader
> made any sense.
>
>>
>> If you think that the way bootloaders is currently managed by live-build is
>> wrong please file up a new bug and send there your patch with your
>> improvements so that it's get discussed.
>
> The bootloader support in live-build is limited. With your patches it
> becomes wrong. eg. compatibility of bootloader with selected
> filesystem and image type is only checked for first bootloader and EFI
> support is added only when grub-efi extra bootloader but not when it
> is the first bootloader.
>
> This is not fixed by renaming the variables.
>
> Thanks
>
> Michal

Ok, what about now? Actually from my former email I only added one 
additional patch (0011) with some sort of modular support for bootloaders.

There probably needs some work to be done on binary_hdd but I first 
wanted to gather information on what to improve on this last patch.


https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_6


adrian15
-- 
Support free software. Donate to Super Grub Disk. Apoya el software 
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/

[0001-functions-default.sh-Define-LB_PRIMARY_BOOTLOADER-at.patch (text/x-patch, attachment)]
[0002-Remove-repeated-LB_PRIMARY_BOOTLOADER-definition.patch (text/x-patch, attachment)]
[0003-Added-functions-bootloaders.sh-.-It-has-new-bootload.patch (text/x-patch, attachment)]
[0004-binary_loopback_cfg-now-renders-grub.cfg-by-default.patch (text/x-patch, attachment)]
[0005-Stolen-efi-image-and-grub-cpmodules-from-src-live-in.patch (text/x-patch, attachment)]
[0006-Support-for-EFI-support-by-the-means-of-grub-efi.patch (text/x-patch, attachment)]
[0007-defaults.sh-LB_BOOTLOADER-updated-to-be-LB_BOOTOADER.patch (text/x-patch, attachment)]
[0008-Many-binary-bootloaders-were-rewritten-to-make-use-o.patch (text/x-patch, attachment)]
[0009-Make-syslinux-grub-efi-the-default-bootloaders-becau.patch (text/x-patch, attachment)]
[0010-Force-the-use-of-insmod-all_video-in-grub.cfg-so-tha.patch (text/x-patch, attachment)]
[0011-binary_grub-efi-works-as-a-first-bootloader-and-as-a.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.

Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 08:58:33 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.