Debian Bug report logs - #900354
lintian: warn against guarding adduser/addgroup calls

Package: lintian; Maintainer for lintian is Debian Lintian Maintainers <[email protected]>; Source for lintian is src:lintian (PTS, buildd, popcon).

Reported by: Julien Cristau <[email protected]>

Date: Tue, 29 May 2018 12:27:02 UTC

Severity: wishlist

Tags: moreinfo

Full log


🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#900354: lintian: warn against guarding adduser/addgroup calls
Reply-To: Julien Cristau <[email protected]>, [email protected]
Resent-From: Julien Cristau <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian Lintian Maintainers <[email protected]>
X-Loop: [email protected]
Resent-Date: Tue, 29 May 2018 14:36:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 900354
X-Debian-PR-Package: lintian
X-Debian-PR-Keywords: moreinfo
References: <[email protected]> <1527604091.383101.1389154520.383B9C5F@webmail.messagingengine.com> <[email protected]>
X-Debian-PR-Source: lintian
Received: via spool by [email protected] id=B900354.152760440721875
          (code B ref 900354); Tue, 29 May 2018 14:36:01 +0000
Received: (at 900354) by bugs.debian.org; 29 May 2018 14:33:27 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1-bugs.debian.org_2005_01_02
	(2015-04-28) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-18.5 required=4.0 tests=BAYES_00,FROMDEVELOPER,
	HAS_BUG_NUMBER,RCVD_IN_DNSWL_NONE,TXREP autolearn=ham autolearn_force=no
	version=3.4.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 14; hammy, 145; neutral, 37; spammy,
	0. spammytokens: hammytokens:0.000-+--H*F:U*jcristau,
	0.000-+--Hx-spam-relays-external:!IPv6, 0.000-+--H*RU:sk:topinam,
	0.000-+--H*r:sk:topinam, 0.000-+--lintian
Received: from topinambour.cristau.org ([2001:bc8:3f1d:100::1])
	by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <[email protected]>)
	id 1fNfgl-0005gY-Ah
	for [email protected]; Tue, 29 May 2018 14:33:27 +0000
Received: from topinambour.cristau.org (localhost [127.0.0.1])
	by topinambour.cristau.org (Postfix) with ESMTP id ED2A52E024E;
	Tue, 29 May 2018 16:33:22 +0200 (CEST)
Received: from [IPv6:2a00:8c40:243:232:759f:f3c4:37:da11] (unknown [IPv6:2a00:8c40:243:232:759f:f3c4:37:da11])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by topinambour.cristau.org (Postfix) with ESMTPSA id 9C8692E00D5;
	Tue, 29 May 2018 16:33:22 +0200 (CEST)
To: Chris Lamb <[email protected]>, [email protected],
 Peter Palfrader <[email protected]>
From: Julien Cristau <[email protected]>
Message-ID: <[email protected]>
Date: Tue, 29 May 2018 16:33:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1527604091.383101.1389154520.383B9C5F@webmail.messagingengine.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
On 05/29/2018 04:28 PM, Chris Lamb wrote:
> tags 900354 + moreinfo
> thanks
> 
> Hi Julien,
> 
> Thanks for the report.
> 
>> <@weasel> "guarding adduser calls considered harmful"
> 
> … regardless of --system or? oh, some concrete examples of "good" and
> "bad" would be really helpful here in ensuring we implement exactly
> what you after if you could spend a couple of seconds on that?
> 
I would think adduser/addgroup without --system in maintainer scripts
should be verboten altogether.  I'll try to poke through codesearch to
find other examples later.

Cheers,
Julien

Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 11:43:32 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.