Debian Bug report logs - #900354
lintian: warn against guarding adduser/addgroup calls

Package: lintian; Maintainer for lintian is Debian Lintian Maintainers <[email protected]>; Source for lintian is src:lintian (PTS, buildd, popcon).

Reported by: Julien Cristau <[email protected]>

Date: Tue, 29 May 2018 12:27:02 UTC

Severity: wishlist

Tags: moreinfo

Full log


🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#900354: lintian: warn against guarding adduser/addgroup calls
Reply-To: Chris Lamb <[email protected]>, [email protected]
Resent-From: Chris Lamb <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian Lintian Maintainers <[email protected]>
X-Loop: [email protected]
Resent-Date: Fri, 01 Jun 2018 08:27:02 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 900354
X-Debian-PR-Package: lintian
X-Debian-PR-Keywords: moreinfo
References: <[email protected]> <1527604091.383101.1389154520.383B9C5F@webmail.messagingengine.com> <[email protected]> <[email protected]>
X-Debian-PR-Source: lintian
Received: via spool by [email protected] id=B900354.15278413666668
          (code B ref 900354); Fri, 01 Jun 2018 08:27:02 +0000
Received: (at 900354) by bugs.debian.org; 1 Jun 2018 08:22:46 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1-bugs.debian.org_2005_01_02
	(2015-04-28) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-18.6 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,FROMDEVELOPER,HAS_BUG_NUMBER,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,TXREP
	autolearn=ham autolearn_force=no version=3.4.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 18; hammy, 110; neutral, 46; spammy,
	2. spammytokens:0.951-+--receiving, 0.856-+--forward
	hammytokens:0.000-+--U*lamby, 0.000-+--sk:lamby@d, 0.000-+--sk:lambyd,
	0.000-+--lambydebianorg, [email protected]
Received: from out1-smtp.messagingengine.com ([66.111.4.25])
	by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <[email protected]>)
	id 1fOfKg-0001jL-3a
	for [email protected]; Fri, 01 Jun 2018 08:22:46 +0000
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailout.nyi.internal (Postfix) with ESMTP id 2F89121CA1;
	Fri,  1 Jun 2018 04:22:45 -0400 (EDT)
Received: from web1 ([10.202.2.211])
  by compute4.internal (MEProxy); Fri, 01 Jun 2018 04:22:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+8IVT1
	n3nuxyp8ROqsr+EpgoLJJQL97ibUDPnZizhMA=; b=I4euv6/58w0jE7GChnILa1
	aBc9JSnhT++xACFJRMEaPWaG1nsG16FKdZ7GnqMthKSWMuKQ+LRYCp+JSV5vK2lt
	yS9Zx7EyQ0eyKH1Muk5PMAcGOjaJtKI+AIzRgDGfD0CZxWVz2ZuyXjfA2tT+b57n
	WTu7zDhuhWz9F+QjrYQ/gwXEn3itAfz7RqO5rfjqbjNZth4Dv5dEAdKzhWhNMcH2
	HSD7viPhNhPzAkXbL2IRwi9Z+liFDDR4IEfxnd2EzXypkjWs1izQPiCApERVnrP1
	YZiz+SLGxmdEDckCE48b3PPslZ7a2gCNiQ4wVU6yIiz/lTbg+mHEhJbTgY3Ryi3A
	==
X-ME-Proxy: <xmx:VQIRWxTyyfnhNNIY3DcxnvO3vo-jD7FSBLfH7KflVtjPd4bAzSNr_A>
X-ME-Proxy: <xmx:VQIRW9dfValfGL19ftN4f3JaCXPAg0UrCP_p0SapF6xsLHy9jQyrjA>
X-ME-Proxy: <xmx:VQIRW0Um4ft-KiipNC5QCm82RMmnSWvnGD-pAeDk1fXd9fdwWmM4Vg>
X-ME-Proxy: <xmx:VQIRW_a7_zgBaYljZx-E4i8wtRjacbY37sQL6HTs1ujPYrZn5QhdFQ>
X-ME-Proxy: <xmx:VQIRW5n_pDIn8X0EDAKEcpuV_ZxUypcfqwyUfg2vJOKaNid2hfeTJw>
X-ME-Proxy: <xmx:VQIRW15MZY_G9EdnDof0MyeGOcN9Eld4nX1KUnaZY3b5uARZm4Cp5A>
X-ME-Sender: <xms:VQIRW_khWIq5v8YPD6UGfK-kl9pFt5XI4L4gL9X4Uko4PUhKAhJzMA>
Received: by mailuser.nyi.internal (Postfix, from userid 99)
	id E76FA9414A; Fri,  1 Jun 2018 04:22:44 -0400 (EDT)
Message-Id: <1527841364.961713.1392758048.7D34BB94@webmail.messagingengine.com>
From: Chris Lamb <[email protected]>
To: Julien Cristau <[email protected]>, [email protected],
 Peter Palfrader <[email protected]>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-397f98d6
Date: Fri, 01 Jun 2018 09:22:44 +0100
In-Reply-To: <[email protected]>
Dear Julien,

> >> <@weasel> "guarding adduser calls considered harmful"
> > 
> > … regardless of --system or? oh, some concrete examples of "good" and
> > "bad" would be really helpful here in ensuring we implement exactly
> > what you after if you could spend a couple of seconds on that?
> > 
> I would think adduser/addgroup without --system in maintainer scripts
> should be verboten altogether.  I'll try to poke through codesearch to
> find other examples later.

Great stuff — looking forward to receiving these. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 11:48:55 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.