Debian Bug report logs - #956627
e4crypt: set_policy and add_key can both fail but return exit code 0

Reply or subscribe to this bug.

Display info messages

Message #5 received at [email protected] (full text, mbox, reply):

From: Daniel Kahn Gillmor <[email protected]>

To: [email protected]

Subject: e4crypt: set_policy and add_key can both fail but return exit code 0

Date: Mon, 13 Apr 2020 14:46:43 -0400

[Message part 1 (text/plain, inline)]

Package: e2fsprogs
Version: 1.45.6-1

When e4crypt fails, it should return a non-zero exit code.

here is add_key succeeding and then failing.  note that $? is the first
element in the prompt.  This shows that the return code remains 0 even
though "add_key" fails to add a new key.

0 dkg@alice:~$ /usr/sbin/e4crypt add_key
Enter passphrase (echo disabled): 
Added key with descriptor [214ee2a37ebdd0bf]
0 dkg@alice:~$ /usr/sbin/e4crypt add_key
Enter passphrase (echo disabled): 
Key with descriptor [214ee2a37ebdd0bf] already exists
0 dkg@alice:~$ 

Here is set_policy failing but still returning 0:

0 dkg@alice:~$ /usr/sbin/e4crypt set_policy 214ee2a37ebdd0bf foobar
Error [File exists] setting policy.
The key descriptor [214ee2a37ebdd0bf] may not match the existing encryption context for directory [foobar].
0 dkg@alice:~$ 


Regards,

        --dkg

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.