Subject: lintian: bad name for duplicate-globbing-patterns and redundant-globbing-patterns
Date: Thu, 06 Aug 2020 15:12:44 +0200
Package: lintian
Version: 2.87.0
Severity: normal
User: [email protected]
Usertags: origin-kali
I was hit with those errors (reproducible with commit
cd6b90a5295aa5a171a1ac9c3c51590f568ca075 in the openvas-scanner git
repository):
E: openvas-scanner source: duplicate-globbing-patterns tools/greenbone-nvt-sync.in in lines 12 12
E: openvas-scanner source: redundant-globbing-patterns [tools/greenbone-nvt-sync.in tools/greenbone-nvt-sync.in] for tools/greenbone-nvt-sync.in
I have multiple issues:
1/ it's not clear that the problem is in the copyright file, I first
looked up tools/greenbone-nvt-sync.in to look what was on line 12
please rename to
{duplicate,redundant}-globbing-patterns-in-debian-copyright for example.
2/ why do I have the same line number twice in the first error?
3/ minor, but ideally we would only report one of the two errors when it
applies to the same file...
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages lintian depends on:
ii binutils 2.35-1
ii bzip2 1.0.8-4
ii diffstat 1.63-1
ii dpkg 1.20.5
ii dpkg-dev 1.20.5
ii file 1:5.38-5
ii gettext 0.19.8.1-10
ii gpg 2.2.20-1
ii intltool-debian 0.35.0+20060710.5
ii libapt-pkg-perl 0.1.36+b3
ii libarchive-zip-perl 1.68-1
ii libcapture-tiny-perl 0.48-1
ii libclass-xsaccessor-perl 1.19-3+b5
ii libclone-perl 0.45-1
ii libconfig-tiny-perl 2.24-1
ii libcpanel-json-xs-perl 4.19-1
ii libdata-dpath-perl 0.58-1
ii libdata-validate-___domain-perl 0.10-1
ii libdevel-size-perl 0.83-1+b1
ii libdpkg-perl 1.20.5
ii libemail-address-xs-perl 1.04-1+b2
ii libfile-basedir-perl 0.08-1
ii libfile-find-rule-perl 0.34-1
ii libfont-ttf-perl 1.06-1
ii libhtml-parser-perl 3.72-5
ii libio-async-loop-epoll-perl 0.21-1
ii libio-async-perl 0.77-3
ii libipc-run3-perl 0.048-2
ii libjson-maybexs-perl 1.004002-1
ii liblist-compare-perl 0.53-1
ii liblist-moreutils-perl 0.416-1+b5
ii liblist-utilsby-perl 0.11-1
ii libmoo-perl 2.004000-1
ii libmoox-aliases-perl 0.001006-1
ii libnamespace-clean-perl 0.27-1
ii libpath-tiny-perl 0.114-1
ii libperlio-gzip-perl 0.19-1+b6
ii libsereal-decoder-perl 4.017+ds-1
ii libsereal-encoder-perl 4.017+ds-1
ii libtext-levenshteinxs-perl 0.03-4+b7
ii libtext-xslate-perl 3.5.8-1
ii libtime-duration-perl 1.21-1
ii libtime-moment-perl 0.44-1+b2
ii libtimedate-perl 2.3300-1
ii libtry-tiny-perl 0.30-1
ii libtype-tiny-perl 1.010002-1
ii libunicode-utf8-perl 0.62-1+b1
ii liburi-perl 1.76-2
ii libxml-libxml-perl 2.0134+dfsg-2
ii libxml-writer-perl 0.625-1
ii libyaml-libyaml-perl 0.82+repack-1
ii lzip 1.21-7
ii man-db 2.9.3-2
ii patchutils 0.4.2-1
ii perl [libdigest-sha-perl] 5.30.3-4
ii t1utils 1.41-4
ii xz-utils 5.2.4-1+b1
lintian recommends no packages.
Versions of packages lintian suggests:
pn binutils-multiarch <none>
ii libtext-template-perl 1.59-1
-- no debconf information
Acknowledgement sent
to Otto Kekäläinen <[email protected]>:
Extra info received and forwarded to list. Copy sent to Debian Lintian Maintainers <[email protected]>.
(Thu, 13 Aug 2020 16:00:03 GMT) (full text, mbox, link).
Subject: lintian: bad name for duplicate-globbing-patterns and redundant-globbing-patterns
Date: Thu, 13 Aug 2020 18:44:48 +0300
Hello!
I agree with Raphaël's comments. The wording of this error could be
improved a bit.
In https://mariadb-team.pages.debian.net/-/mariadb-10.3/-/jobs/929803/artifacts/debian/output/lintian.html
I got
E duplicate-globbing-patterns mysql-test/mysql-stress-test.pl in lines
213 467 467
E duplicate-globbing-patterns storage/innobase/fts/fts0pars.cc in lines 590 590
E duplicate-globbing-patterns
storage/tokudb/PerconaFT/third_party/xz-4.999.9beta/lib/getopt_int.h
in lines 769 800
E duplicate-globbing-patterns strings/strxmov.c in lines 355 355
E duplicate-globbing-patterns strings/strxnmov.c in lines 355 355
E redundant-globbing-patterns [client/* client/echo.c] for client/echo.c
E redundant-globbing-patterns [mysql-test/mysql-stress-test.pl
mysql-test/mysql-stress-test.pl] for mysql-test/mysql-stress-test.pl
E redundant-globbing-patterns [storage/innobase/fts/fts0pars.cc
storage/innobase/fts/fts0pars.cc] for storage/innobase/fts/fts0pars.cc
E redundant-globbing-patterns [strings/strxmov.c strings/strxmov.c]
for strings/strxmov.c
E redundant-globbing-patterns [strings/strxnmov.c strings/strxnmov.c]
for strings/strxnmov.c
-> 6 errors would have been enough, now there are 10
-> some have identical line numbers twice
Also, I was unable to find it's documentation at the usual ___location at
https://lintian.debian.org/tags/duplicate-globbing-patterns.html
Never the less, the usability was good enough that I was able to fix
the issues and now Lintian passes for this package. This is just a
minor improvement suggestion.
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.