Debian Bug report logs - #986206
qmake drops options passed from QMAKE_CXXFLAGS_RELEASE and QMAKE_CXXFLAGS_DEBUG

version graph

Package: src:guymager; Maintainer for src:guymager is Debian Security Tools <[email protected]>;

Reported by: Matthias Klose <[email protected]>

Date: Wed, 31 Mar 2021 15:33:02 UTC

Severity: important

Tags: bookworm, bullseye, sid, trixie

Found in version guymager/0.8.12-1

Full log


🔗 View this message in rfc822 format

X-Loop: [email protected]
Subject: Bug#986206: qmake drops options passed from QMAKE_CXXFLAGS_RELEASE and QMAKE_CXXFLAGS_DEBUG
Reply-To: Dmitry Shachnev <[email protected]>, [email protected]
Resent-From: Dmitry Shachnev <[email protected]>
Resent-To: [email protected]
Resent-CC: Debian Qt/KDE Maintainers <[email protected]>
X-Loop: [email protected]
Resent-Date: Wed, 31 Mar 2021 16:57:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Debian-PR-Message: followup 986206
X-Debian-PR-Package: qt5-qmake
X-Debian-PR-Keywords: bullseye sid
References: <[email protected]> <[email protected]>
X-Debian-PR-Source: qtbase-opensource-src
Received: via spool by [email protected] id=B986206.1617209770698
          (code B ref 986206); Wed, 31 Mar 2021 16:57:01 +0000
Received: (at 986206) by bugs.debian.org; 31 Mar 2021 16:56:10 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2-bugs.debian.org_2005_01_02
	(2018-09-13) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-18.3 required=4.0 tests=BAYES_00,
	FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
	FROMDEVELOPER,FVGT_m_MULTI_ODD,HAS_BUG_NUMBER,
	HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
	SPF_HELO_NONE,SPF_PASS,TXREP,T_PDS_PRO_TLD autolearn=ham
	autolearn_force=no version=3.4.2-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 25; hammy, 150; neutral, 53; spammy,
	0. spammytokens: hammytokens:0.000-+--dpkg-buildflags,
	0.000-+--dpkgbuildflags, 0.000-+--Shachnev, 0.000-+--shachnev,
	0.000-+--cxxflags
Received: from mail-ed1-f45.google.com ([209.85.208.45]:37744)
	by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <[email protected]>)
	id 1lRe8Y-0000Ar-2X
	for [email protected]; Wed, 31 Mar 2021 16:56:10 +0000
Received: by mail-ed1-f45.google.com with SMTP id x21so23119690eds.4
        for <[email protected]>; Wed, 31 Mar 2021 09:56:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=vcCvBI/5anliNs/QTCl205WyHDehBUFjE5fcQPSSEvM=;
        b=Z0C+dvPueWSbMBecHI+ms4GP0tRp+6abGKdxncSTnpPbDQD+dN9eo6OZfeqtDq2aQL
         Qjg6Ee5IIMKJrownZ6N1CJQACmBszaf04/ei/ICkyxQgKTK58Y4nLSr4a8kDpF5d+NFy
         vs5LMBq2U1+jbAPaViV5yNSFra8q3TbBZubBp4rx4buUvfcHptafnzdwmjwC4J2erL/D
         HNxgG+tUiyPOA+vC1lFC5NzYdDRTO6X6ftkRaY9moz2dDv3km1FHNpLiypi2q3pK6nMg
         UdwllIwIcVMY/qEOESO2SZe8SJr0gcT60ejGIgaXmiLEJFrhUnrdjikt2Pprhr3eE8/U
         8yPw==
X-Gm-Message-State: AOAM53263rcLDSR/bvOTN5RQghTd0JMiCUXg9z7ZyeTIc7smTFq/jkcy
	4G9KS8HOrjfJzDQblRkhjrQ=
X-Google-Smtp-Source: ABdhPJxM9i0MFzZBhZgw8FwZs4oV9Gw/Jb7PjFcj9ivBgCV/0x1VwE3LfCd+FSTWNyQbycTKUovotg==
X-Received: by 2002:aa7:de8b:: with SMTP id j11mr4916554edv.363.1617209766775;
        Wed, 31 Mar 2021 09:56:06 -0700 (PDT)
Received: from mitya57.me ([2a03:b0c0:0:1010::3b:3001])
        by smtp.gmail.com with ESMTPSA id c12sm2199100edx.54.2021.03.31.09.56.05
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 31 Mar 2021 09:56:05 -0700 (PDT)
Date: Wed, 31 Mar 2021 19:56:04 +0300
From: Dmitry Shachnev <[email protected]>
To: Matthias Klose <[email protected]>, [email protected]
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
Control: reassign -1 src:guymager 0.8.12-1
Control: severity -1 important

Hi Matthias!

On Wed, Mar 31, 2021 at 05:30:17PM +0200, Matthias Klose wrote:
> seen when building guymager, adding to the rules file:
>
> export DEB_CXXFLAGS_MAINT_APPEND = --param ggc-min-expand=0 --param
> ggc-min-heapsize=0
>
> The generated Makefile isn't correctly generated. The "# Command" line shows the
> passed args, which are correct, however the "^CXXFLAGS" line shows that the
> flags are expanded twice, and the first time, the second --param option is
> omitted, but not the parameter following that option.

This happens because guymager.pro line 150 has this:

  QMAKE_CXXFLAGS *= $$system(dpkg-buildflags --get CXXFLAGS)

The *= operator is for adding unique values (as opposed to +=). The --param
flag appears twice, so it keeps only the first instance:

https://doc.qt.io/qt-5/qmake-language.html#adding-unique-values

You can use --param=ggc-min-expand=0 --param=ggc-min-heapsize=0, then there
will be no such problem.

Also there is no need at all to call dpkg-buildflags from the .pro file.
debhelper passes all needed flags via command line arguments.

> Feel free to reassign to guymager and lowering the severity, if that is not
> a generic qmake issue.

Doing so.

Dear guymager maintainer(s): please consider removing lines 150 and 151 from
guymager.pro, or at least replacing *= with +=.

--
Dmitry Shachnev

Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 14:20:25 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.