Skip to content

Update CNA tests to avoid publish conflict #57025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 18, 2023

This avoids testing against latest exact canary version as this causes these tests to fail while the publish is still in progress. As a follow-up we can investigate moving this post publish or packing/deploying tarballs to use.

huozhi
huozhi previously approved these changes Oct 18, 2023
styfle
styfle previously approved these changes Oct 18, 2023
@ijjk
Copy link
Member Author

ijjk commented Oct 18, 2023

Tests Passed

@ijjk
Copy link
Member Author

ijjk commented Oct 18, 2023

Stats from current PR

Default Build
General
vercel/next.js canary ijjk/next.js fix/cna-tests Change
buildDuration 10.6s 10.7s N/A
buildDurationCached 6.1s 6.4s ⚠️ +246ms
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 513ms 512ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/cna-tests Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.8 kB 98.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/cna-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/cna-tests Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/cna-tests Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/cna-tests Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js fix/cna-tests Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js fix/cna-tests Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 04a463a

@styfle styfle dismissed stale reviews from huozhi and themself via a544f2b October 19, 2023 02:09
@styfle styfle requested a review from a team as a code owner October 19, 2023 02:09
styfle
styfle previously approved these changes Oct 19, 2023
@kodiakhq kodiakhq bot merged commit 3010ae1 into vercel:canary Oct 19, 2023
@ijjk ijjk deleted the fix/cna-tests branch October 19, 2023 23:01
@ijjk ijjk mentioned this pull request Oct 19, 2023
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2023
Follow-up to #57025 this updates other places we run the `create-next-app` CLI in tests.
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants