Skip to content

enable e2e tests with turbopack #57432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2023
Merged

enable e2e tests with turbopack #57432

merged 3 commits into from
Oct 25, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 25, 2023 •
edited by padmaia
Loading

Closes WEB-1862

@sokra sokra requested review from a team as code owners October 25, 2023 17:20
@sokra sokra requested review from ismaelrumzan and StephDietz and removed request for a team October 25, 2023 17:20
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Oct 25, 2023
kwonoj
kwonoj previously approved these changes Oct 25, 2023
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/e2e Change
buildDuration 10.4s 10.2s N/A
buildDurationCached 5.9s 5.9s N/A
nodeModulesSize 175 MB 175 MB ✓
nextStartRea..uration (ms) 415ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/e2e Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/e2e Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/e2e Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB ✓
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.99 kB 3.99 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/e2e Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/e2e Change
index.html gzip 528 B 530 B N/A
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 524 B ✓
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/e2e Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 139 kB 140 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/e2e Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: 54359d3

@sokra sokra requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners October 25, 2023 17:33
kwonoj
kwonoj reviewed Oct 25, 2023
View reviewed changes
test/turbopack-tests-manifest.json
"app dir - metadata dynamic routes text routes should handle robots.[ext] dynamic routes"
],
"failed": [
"app dir - metadata dynamic routes should error when id is missing in generateSitemaps",
"app dir - metadata dynamic routes should generate unique path for image routes under group routes",
"app dir - metadata dynamic routes should inject dynamic metadata properly to head",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57431 is in canary, so rebasing should make pass some of these tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated from the daily test run... The next run will make it pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but there's passing test and don't need to move to failed manually? but it's indifferent

@sokra sokra merged commit 462b858 into canary Oct 25, 2023
@sokra sokra deleted the sokra/e2e branch October 25, 2023 17:46
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @kwonoj