Skip to content

fix(turbopack): don't emit issues when parsing the segment config for non js files #57452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(turbopack): don't emit issues when parsing the segment config for non js files #57452

merged 1 commit into from
Oct 25, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Oct 25, 2023 •
edited by padmaia
Loading

Why?

Calling parse will emit issues with error severity, causing the build to get marked as failed

Closes WEB-1869

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Oct 25, 2023
kwonoj
kwonoj reviewed Oct 25, 2023
View reviewed changes
packages/next-swc/crates/next-core/src/app_segment_config.rs
@@ -211,6 +211,16 @@ pub async fn parse_segment_config_from_source(
) -> Result<Vc<NextSegmentConfig>> {
let path = source.ident().path().await?;

// Don't try parsing if it's not a javascript file, otherwise it will emit an
// issue causing the build to "fail".
if !(path.path.ends_with(".js")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to not include some other extensions like cjs / mjs / cts.. ?

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
buildDuration 10.5s 10.4s N/A
buildDurationCached 5.8s 6s ⚠️ +235ms
nodeModulesSize 175 MB 175 MB ✓
nextStartRea..uration (ms) 423ms 416ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB ✓
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.99 kB 3.99 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
index.html gzip 528 B 529 B N/A
link.html gzip 542 B 542 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.07 kB 1.07 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js hrmny/fix-segment-config-mdx-error Change
middleware-b..fest.js gzip 624 B 620 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: fc6c09b

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023 •
edited
Loading

Tests Passed

@sokra sokra merged commit 32e2317 into canary Oct 25, 2023
@sokra sokra deleted the hrmny/fix-segment-config-mdx-error branch October 25, 2023 23:29
ztanner pushed a commit that referenced this pull request Oct 26, 2023
@ForsakenHarmony @ztanner
fix(turbopack): don't emit issues when parsing the segment config for…
78a194d 
… non js files (#57452)

### Why?

Calling `parse` will emit issues with error severity, causing the build
to get marked as failed


Closes WEB-1869
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj left review comments

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ForsakenHarmony @ijjk @kwonoj @sokra