-
Notifications
You must be signed in to change notification settings - Fork 28.4k
Ignore postponed rejections #57456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ignore postponed rejections #57456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedthejim
previously approved these changes
Oct 25, 2023
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
buildDuration | 10.5s | 10.5s | N/A |
buildDurationCached | 6.2s | 6s | N/A |
nodeModulesSize | 175 MB | 175 MB | |
nextStartRea..uration (ms) | 399ms | 396ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
199-HASH.js gzip | 32.3 kB | 32.4 kB | N/A |
3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | N/A |
99.HASH.js gzip | 182 B | 182 B | ✓ |
framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
main-app-HASH.js gzip | 253 B | 251 B | N/A |
main-HASH.js gzip | 35.3 kB | 35.4 kB | N/A |
webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
Overall change | 45.7 kB | 45.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
_app-HASH.js gzip | 206 B | 205 B | N/A |
_error-HASH.js gzip | 182 B | 180 B | N/A |
amp-HASH.js gzip | 506 B | 505 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | ✓ |
edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 369 B | 369 B | ✓ |
image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 316 B | 318 B | N/A |
script-HASH.js gzip | 385 B | 384 B | N/A |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.99 kB | 3.99 kB | ✓ |
Client Build Manifests
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 482 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
index.html gzip | 528 B | 529 B | N/A |
link.html gzip | 542 B | 542 B | ✓ |
withRouter.html gzip | 524 B | 524 B | ✓ |
Overall change | 1.07 kB | 1.07 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
edge-ssr.js gzip | 96 kB | 96 kB | N/A |
page.js gzip | 140 kB | 140 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | sebmarkbage/next.js fixpostponeerror | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 625 B | 622 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 25.6 kB | 25.6 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
timneutkens
previously approved these changes
Oct 25, 2023
We also don't warn for awaiting a Promise late. That's a fine pattern in Next.js because it allows for fetching early and awaiting late. If a Promise does reject before that we still log an error which is fine because an error actually did happen even if we didn't await it. We ignore postpones though because they are not unexpected.
73ea419
37fb10f
to
73ea419
Compare
Tests Passed |
feedthejim
previously approved these changes
Oct 26, 2023
sebmarkbage
commented
Oct 26, 2023
sebmarkbage
commented
Oct 26, 2023
feedthejim
approved these changes
Oct 26, 2023
ztanner
pushed a commit
that referenced
this pull request
Oct 26, 2023
We also don't warn for awaiting a Promise late. That's a fine pattern in Next.js because it allows for fetching early and awaiting late. If a Promise does reject before that we still log an error which is fine because an error actually did happen even if we didn't await it. We ignore postpones though because they are not unexpected. --------- Co-authored-by: Jimmy Lai <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also don't warn for awaiting a Promise late. That's a fine pattern in Next.js because it allows for fetching early and awaiting late.
If a Promise does reject before that we still log an error which is fine because an error actually did happen even if we didn't await it.
We ignore postpones though because they are not unexpected.