-
Notifications
You must be signed in to change notification settings - Fork 28.4k
turbopack: Fix Server Actions in Edge runtime #57462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
previously approved these changes
Oct 26, 2023
timneutkens
previously approved these changes
Oct 26, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
sokra
previously approved these changes
Oct 26, 2023
sokra
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes Server Actions to use a lazy
require()
statement instead of a lazy dynamicimport()
, to fix SA in the Edge runtime.Why?
The Edge runtime has a restriction that it's not allowed to lazy load more files. The problem is that dynamic
import()
does exactly that, it defers importing those files until the call time.require()
doesn't have this issue, because the chunks it would load are included instead of deferred.How?
Just needed to modify the actions loader entry point… after hours of trying to get the action loader to evaluate in the node runtime and then import the actions in the edge runtime.
Closes WEB-1874