Debian Bug report logs - #463336
git/post-receive-email: allow customizing the subject, intro, and footer

version graph

Package: git; Maintainer for git is Jonathan Nieder <[email protected]>; Source for git is src:git (PTS, buildd, popcon).

Reported by: Luca Capello <[email protected]>

Date: Wed, 30 Jan 2008 23:21:01 UTC

Severity: wishlist

Tags: patch, upstream

Merged with 463316

Found in versions git/1:1.5.3.8-1, git/1:1.7.1-1

Forwarded to http://thread.gmane.org/gmane.comp.version-control.git/137426

Reply or subscribe to this bug.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to [email protected], Luca Capello <[email protected]>, Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Luca Capello <[email protected]>:
New Bug report received and forwarded. Copy sent to Luca Capello <[email protected]>, Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #5 received at [email protected] (full text, mbox, reply):

From: Luca Capello <[email protected]>
To: Debian Bug Tracking System <[email protected]>
Subject: git-core: [hooks/post-receive-email] option to set the project name
Date: Thu, 31 Jan 2008 00:19:04 +0100
[Message part 1 (text/plain, inline)]
Package: git-core
Version: 1:1.5.3.8-1
Severity: wishlist

Hello,

if the project description is quite long, the email subject becomes
really long.  I'd like an option to have the project name instead of the
project description in the email subject.  To avoid regressions, the
project name should default to the project description.

BTW, as soon as the BTS will assign a bug number, I'll post the git
patch.

Thx, bye,
Gismo / Luca

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages git-core depends on:
ii  cpio                   2.9-9             GNU cpio -- a program to manage ar
ii  libc6                  2.7-6             GNU C Library: Shared libraries
ii  libcurl3-gnutls        7.17.1-1+b1       Multi-protocol file transfer libra
ii  libdigest-sha1-perl    2.11-2            NIST SHA-1 message digest algorith
ii  liberror-perl          0.17-1            Perl module for error/exception ha
ii  libexpat1              1.95.8-4          XML parsing C library - runtime li
ii  perl-modules           5.8.8-12          Core Perl modules
ii  zlib1g                 1:1.2.3.3.dfsg-11 compression library - runtime

Versions of packages git-core recommends:
ii  curl                         7.17.1-1+b1 Get a file from an HTTP, HTTPS or 
ii  less                         418-1       Pager program similar to more
ii  openssh-client [ssh-client]  1:4.7p1-2   secure shell client, an rlogin/rsh
ii  patch                        2.5.9-4     Apply a diff file to an original
ii  rsync                        2.6.9-6     fast remote file copy program (lik

-- no debconf information
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Luca Capello <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #10 received at [email protected] (full text, mbox, reply):

From: Luca Capello <[email protected]>
To: [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Thu, 31 Jan 2008 00:30:36 +0100
[Message part 1 (text/plain, inline)]
tags 463336 + patch
thanks

Hello!

On Thu, 31 Jan 2008 00:19:04 +0100, Luca Capello wrote:
> BTW, as soon as the BTS will assign a bug number, I'll post the git
> patch.

Attached and also available on my git repository [1].

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://git.debian.org/?p=users/gismo/git.git;a=summary

[0002-contrib-hooks-post-receive-email-add-hooks.projectn.patch (text/x-diff, attachment)]
[Message part 3 (application/pgp-signature, inline)]

Tags added: patch Request was from Luca Capello <[email protected]> to [email protected]. (Wed, 30 Jan 2008 23:33:04 GMT) (full text, mbox, link).


Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Sebastian Harl <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #17 received at [email protected] (full text, mbox, reply):

From: Sebastian Harl <[email protected]>
To: Luca Capello <[email protected]>, [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Fri, 1 Feb 2008 14:38:37 +0100
[Message part 1 (text/plain, inline)]
Hi Luca,

On Thu, Jan 31, 2008 at 12:19:04AM +0100, Luca Capello wrote:
> BTW, as soon as the BTS will assign a bug number, I'll post the git
> patch.

Just a side-note: Are you aware that you may send a patch (including the
appropriate tag) along with your original bug report?

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

[signature.asc (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Luca Capello <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #22 received at [email protected] (full text, mbox, reply):

From: Luca Capello <[email protected]>
To: Sebastian Harl <[email protected]>
Cc: [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Fri, 01 Feb 2008 15:50:17 +0100
[Message part 1 (text/plain, inline)]
Hi Sebastian!

On Fri, 01 Feb 2008 14:38:37 +0100, Sebastian Harl wrote:
> On Thu, Jan 31, 2008 at 12:19:04AM +0100, Luca Capello wrote:
>> BTW, as soon as the BTS will assign a bug number, I'll post the git
>> patch.
>
> Just a side-note: Are you aware that you may send a patch (including
> the appropriate tag) along with your original bug report?

For the patch: do you mean the one at [1], also available on my git
repository [2]?  In case not, what kind of patch?

Otherwise, maybe are you talking about sending the patch upstream?  I'd
avoid that, since AFAIK git-core maintainer (hi, Gerrit!) has commit
access to the upstream git [3] and thus I'd prefer him dealing with
upstream.

The rationale behind myself filing Debian bugs instead of directly
upstream is that these improvements arose when I start playing with
git.d.o [4].

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=463336#10
[2] http://git.debian.org/?p=users/gismo/git.git;a=summary
[3] http://git.kernel.org/?p=git/git.git;a=commit;h=e7509ee388480046a685f885431291f484de66de
[4] http://alioth.debian.org/tracker/index.php?func=detail&aid=310547&group_id=1&atid=200001
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Sebastian Harl <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #27 received at [email protected] (full text, mbox, reply):

From: Sebastian Harl <[email protected]>
To: Luca Capello <[email protected]>
Cc: [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Fri, 1 Feb 2008 16:41:18 +0100
[Message part 1 (text/plain, inline)]
Hi Luca,

On Fri, Feb 01, 2008 at 03:50:17PM +0100, Luca Capello wrote:
> On Fri, 01 Feb 2008 14:38:37 +0100, Sebastian Harl wrote:
> > On Thu, Jan 31, 2008 at 12:19:04AM +0100, Luca Capello wrote:
> >> BTW, as soon as the BTS will assign a bug number, I'll post the git
> >> patch.
> >
> > Just a side-note: Are you aware that you may send a patch (including
> > the appropriate tag) along with your original bug report?
> 
> For the patch: do you mean the one at [1], also available on my git
> repository [2]?  In case not, what kind of patch?
[...]

No, I was just saying that you do not need to wait for a bug number
being assigned to a bug if you want to provide a patch - you can simply
include that patch into your original bug report (i.e. the E-mail you're
sending to [email protected]). This was just meant as a general note and not
related to any specific bug report.

Cheers,
Sebastian

PS: I should not have replied to the BTS in the first place - please
take this to a private conversation if you have further comments.

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

[signature.asc (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Luca Capello <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #32 received at [email protected] (full text, mbox, reply):

From: Luca Capello <[email protected]>
To: Sebastian Harl <[email protected]>
Cc: [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Sat, 02 Feb 2008 11:44:04 +0100
[Message part 1 (text/plain, inline)]
Hi Sebastian!

On Fri, 01 Feb 2008 16:41:18 +0100, Sebastian Harl wrote:
> PS: I should not have replied to the BTS in the first place - please
> take this to a private conversation if you have further comments.

Keeping into the PTS, since I think it's a useful discussion.

> On Fri, Feb 01, 2008 at 03:50:17PM +0100, Luca Capello wrote:
>> On Fri, 01 Feb 2008 14:38:37 +0100, Sebastian Harl wrote:
>> > On Thu, Jan 31, 2008 at 12:19:04AM +0100, Luca Capello wrote:
>> >> BTW, as soon as the BTS will assign a bug number, I'll post the git
>> >> patch.
>> >
>> > Just a side-note: Are you aware that you may send a patch (including
>> > the appropriate tag) along with your original bug report?
>> 
>> For the patch: do you mean the one at [1], also available on my git
>> repository [2]?  In case not, what kind of patch?
> [...]
>
> No, I was just saying that you do not need to wait for a bug number
> being assigned to a bug if you want to provide a patch

I based my patch to the one fixing #428418 [1] (upstream at [2]): the
idea is that the *git* patch should be "complete", thus also including
the Debian bug number the patch is trying to fix.

Hope that now it's clear, since this is my workflow every time I deal
with Debian bugs against upstream.

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://bugs.debian.org/428418
[2] http://git.kernel.org/?p=git/git.git;a=commit;h=e7509ee388480046a685f885431291f484de66de
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Sebastian Harl <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #37 received at [email protected] (full text, mbox, reply):

From: Sebastian Harl <[email protected]>
To: Luca Capello <[email protected]>
Cc: [email protected]
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Sat, 2 Feb 2008 13:46:25 +0100
[Message part 1 (text/plain, inline)]
Hi Luca,

On Sat, Feb 02, 2008 at 11:44:04AM +0100, Luca Capello wrote:
> On Fri, 01 Feb 2008 16:41:18 +0100, Sebastian Harl wrote:
> > On Fri, Feb 01, 2008 at 03:50:17PM +0100, Luca Capello wrote:
> >> On Fri, 01 Feb 2008 14:38:37 +0100, Sebastian Harl wrote:
> >> > On Thu, Jan 31, 2008 at 12:19:04AM +0100, Luca Capello wrote:
> >> >> BTW, as soon as the BTS will assign a bug number, I'll post the git
> >> >> patch.
> >> >
> >> > Just a side-note: Are you aware that you may send a patch (including
> >> > the appropriate tag) along with your original bug report?
> >> 
> >> For the patch: do you mean the one at [1], also available on my git
> >> repository [2]?  In case not, what kind of patch?
> > [...]
> >
> > No, I was just saying that you do not need to wait for a bug number
> > being assigned to a bug if you want to provide a patch
> 
> I based my patch to the one fixing #428418 [1] (upstream at [2]): the
> idea is that the *git* patch should be "complete", thus also including
> the Debian bug number the patch is trying to fix.

Oh, I see - sorry for the noise then :-)

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

[signature.asc (application/pgp-signature, inline)]

Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (full text, mbox, link).


Acknowledgement sent to Luca Capello <[email protected]>, [email protected], Sebastian Harl <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (full text, mbox, link).


Message #42 received at [email protected] (full text, mbox, reply):

From: Gerrit Pape <[email protected]>
To: Luca Capello <[email protected]>, [email protected]
Cc: Sebastian Harl <[email protected]>
Subject: Re: Bug#463336: git-core: [hooks/post-receive-email] option to set the project name
Date: Fri, 8 Feb 2008 14:01:42 +0000
On Fri, Feb 01, 2008 at 03:50:17PM +0100, Luca Capello wrote:
> Otherwise, maybe are you talking about sending the patch upstream?  I'd
> avoid that, since AFAIK git-core maintainer (hi, Gerrit!) has commit
> access to the upstream git [3] and thus I'd prefer him dealing with
> upstream.

Hi Luca, I don't have direct commit access, but submit my patches to the
git mailing list where Junio picks them up or not, or comments them.

So if you like you can do just the same instead of waiting for me until
I get to them.  I skimmed over the changes, and am currently not sure
whether they would be accepted as is.  If not, the list members usually
give good advise in their followups.

Regards, Gerrit.




Information forwarded to [email protected], Gerrit Pape <[email protected]>:
Bug#463336; Package git-core. (Sat, 15 May 2010 20:45:06 GMT) (full text, mbox, link).


Acknowledgement sent to Jonathan Nieder <[email protected]>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <[email protected]>. (Sat, 15 May 2010 20:45:06 GMT) (full text, mbox, link).


Message #47 received at [email protected] (full text, mbox, reply):

From: Jonathan Nieder <[email protected]>
To: Luca Capello <[email protected]>
Cc: [email protected]
Subject: Re: [hooks/post-receive-email] option to set the project name
Date: Sat, 15 May 2010 15:40:39 -0500
reassign 463336 git git/1:1.5.3.8-1
found 463336 git/1:1.7.1-1
tags 463336 + upstream
quit

Hi Luca,

Luca Capello wrote:

> if the project description is quite long, the email subject becomes
> really long.  I'd like an option to have the project name instead of the
> project description in the email subject.  To avoid regressions, the
> project name should default to the project description.

Same comments as in http://bugs.debian.org/463316 apply here: what do you
think of Mike Frysinger’s more general solution?

Personally, I suspect this points to it being useful to add more
user-defined substitutions to the hooks.emailsubject variable.  I am not
so happy with complicating the configuration more by default.

Thanks for the report and patch[1],
Jonathan

[1] http://git.debian.org/?p=users/gismo/git.git;h=57c345f2




Bug reassigned from package 'git-core' to 'git'. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 15 May 2010 20:45:08 GMT) (full text, mbox, link).


Bug No longer marked as found in versions git-core/1:1.5.3.8-1. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 15 May 2010 20:45:08 GMT) (full text, mbox, link).


Bug Marked as found in versions git/1:1.5.3.8-1. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 15 May 2010 20:45:09 GMT) (full text, mbox, link).


Bug Marked as found in versions git/1:1.7.1-1. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 15 May 2010 20:45:09 GMT) (full text, mbox, link).


Added tag(s) upstream. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 15 May 2010 20:45:10 GMT) (full text, mbox, link).


Merged 463316 463336. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 19 Feb 2011 02:51:04 GMT) (full text, mbox, link).


Changed Bug title to 'git/post-receive-email: allow customizing the subject, intro, and footer' from 'git-core: [hooks/post-receive-email] option to set the project name' Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 19 Feb 2011 02:51:04 GMT) (full text, mbox, link).


Set Bug forwarded-to-address to 'http://thread.gmane.org/gmane.comp.version-control.git/137426'. Request was from Jonathan Nieder <[email protected]> to [email protected]. (Sat, 19 Feb 2011 02:51:05 GMT) (full text, mbox, link).


Message sent on to Luca Capello <[email protected]>:
Bug#463336. (Sat, 19 Feb 2011 02:51:09 GMT) (full text, mbox, link).


Message #66 received at [email protected] (full text, mbox, reply):

From: Jonathan Nieder <[email protected]>
To: [email protected], [email protected]
Subject: Re: git-core: [hooks/post-receive-email] option to set the project name
Date: Fri, 18 Feb 2011 20:45:58 -0600
tags 463316 + patch
merge 463336 463316
retitle 463316 git/post-receive-email: allow customizing the subject, intro, and footer
# [1]
forwarded 463316 http://thread.gmane.org/gmane.comp.version-control.git/137426
quit

Hi!

Luca Capello wrote:

> if the project description is quite long, the email subject becomes
> really long.

Since I never use post-receive-email myself, I don't think I'll get
around to this.  But I encourage anyone interested to take Mike
Frysinger's patch[1] and build on it or resend it upstream.

Thanks for your work,
Jonathan




Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Tue May 13 12:53:21 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.