Acknowledgement sent
to Marc Haber <[email protected]>:
New Bug report received and forwarded. Copy sent to Héctor García Álvarez <[email protected]>.
(Tue, 15 Sep 2020 07:03:03 GMT) (full text, mbox, link).
Subject: assertion failed in vte_terminal_spawn_with_fds_async
Date: Tue, 15 Sep 2020 09:01:28 +0200
Package: mssh
Version: 2.2-5+b1
Severity: important
Hi,
after today's sid update, mssh doesn't work any more:
[2/5031]mh@drop:~ $ mssh torres
(mssh:26684): VTE-CRITICAL **: 08:56:36.260: void vte_terminal_spawn_with_fds_async(VteTerminal*, VtePtyFlags, const char*, const char* const*, const char* const*, const int*, int, const int*, int, GSpawnFlags, GSpawnChildSetupFunc, gpointer, GDestroyNotify, int, GCancellable*, VteTerminalSpawnAsyncCallback, gpointer): assertion 'callback' failed
an mssh window opens, but remains empty.
Going back to libvte-2.91-0 0.60.3-1 from bullseye fixes the issue for
me. I cannot judge whether this is libvte breakage or an issue in mssh
uncovered by the libvte update.
Greetings
Marc
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.8.9-zgws1 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages mssh depends on:
ii gconf-service 3.2.6-6
ii gconf2 3.2.6-6
ii libc6 2.31-3
ii libgconf-2-4 3.2.6-6
ii libglib2.0-0 2.66.0-1
ii libgtk-3-0 3.24.23-1
ii libpango-1.0-0 1.46.1-1
ii libvte-2.91-0 0.60.3-1
ii openssh-client 1:8.3p1-1
mssh recommends no packages.
mssh suggests no packages.
-- no debconf information
Subject: assertion failed in vte_terminal_spawn_with_fds_async
Date: Mon, 28 Sep 2020 14:28:26 +0200
Hello,
is there a solution about this bug ?
I can't downgrade libvte-2.91-0 0.60.3-1
Then, i'm very interested by a patch or new version.
Thanks a lot for your help
Pascal
Acknowledgement sent
to Simon McVittie <[email protected]>:
Extra info received and forwarded to list. Copy sent to Héctor García Álvarez <[email protected]>.
(Wed, 30 Sep 2020 14:15:04 GMT) (full text, mbox, link).
Control: retitle 971422 libvte-2.91-0: vte_terminal_spawn_async doesn't accept NULL callback since 0.62
On Wed, 30 Sep 2020 at 12:12:22 +0200, Pascal wrote:
> as described in this bug : https://bugs.debian.org/cgi-
> bin/bugreport.cgi?bug=970356
> It's impossible to launch mssh .
>
> mssh -a serveurs
>
> (mssh:105138): VTE-CRITICAL **: 12:10:20.197: void
> vte_terminal_spawn_with_fds_async(VteTerminal*, VtePtyFlags, const char*, const
> char* const*, const char* const*, const int*, int, const int*, int,
> GSpawnFlags, GSpawnChildSetupFunc, gpointer, GDestroyNotify, int,
> GCancellable*, VteTerminalSpawnAsyncCallback, gpointer): assertion 'callback'
> failed
>
> an mssh window opens, but remains empty.
The documentation for vte_terminal_spawn_async() and its newer version
vte_terminal_spawn_with_fds_async() says it's valid to call them with a
NULL callback, but since 0.62.x the implementation doesn't allow this.
At least one of the documentation or the implementation must be wrong.
This is a regression in libvte-2.91-0: it doesn't accept something
that previously worked. However, mssh can work around this by passing
a non-NULL callback.
I would recommend making mssh use a non-NULL callback *anyway*, because
it's the only way for vte_terminal_spawn_async() to report errors, which
any non-trivial vte user should be reporting in some way. Something like
this should be suitable:
static void
terminal_spawn_async_cb (VteTerminal *terminal,
GPid pid,
GError *error,
gpointer user_data)
{
if (error != NULL)
g_critical ("Error setting up terminal: %s", error->message);
else
g_debug ("Terminal set up, process ID: %d", pid);
}
(Or whatever error handling mssh wants to do instead of complaining on
stderr: for example, it might want to emit the session-closed signal
on errors, or something like that.)
smcv
Acknowledgement sent
to Simon McVittie <[email protected]>:
Extra info received and forwarded to list. Copy sent to Héctor García Álvarez <[email protected]>.
(Wed, 30 Sep 2020 14:27:03 GMT) (full text, mbox, link).
Control: forwarded 971422 https://gitlab.gnome.org/GNOME/vte/-/issues/286
On Wed, 30 Sep 2020 at 15:12:09 +0100, Simon McVittie wrote:
> The documentation for vte_terminal_spawn_async() and its newer version
> vte_terminal_spawn_with_fds_async() says it's valid to call them with a
> NULL callback, but since 0.62.x the implementation doesn't allow this.
I've reported that upstream.
smcv
Acknowledgement sent
to Simon McVittie <[email protected]>:
Extra info received and forwarded to list. Copy sent to Héctor García Álvarez <[email protected]>.
(Wed, 30 Sep 2020 15:06:02 GMT) (full text, mbox, link).
Control: reassign 970356 libvte-2.91-0 0.62.0-1
Control: affects 970356 + mssh
Control: severity 971422 serious
Control: forcemerge 971422 970356
Control: tags 971422 + fixed-upstream pending
On Wed, 30 Sep 2020 at 15:22:37 +0100, Simon McVittie wrote:
> On Wed, 30 Sep 2020 at 15:12:09 +0100, Simon McVittie wrote:
> > The documentation for vte_terminal_spawn_async() and its newer version
> > vte_terminal_spawn_with_fds_async() says it's valid to call them with a
> > NULL callback, but since 0.62.x the implementation doesn't allow this.
>
> I've reported that upstream.
Now fixed upstream. I'll upload a fixed version soon.
mssh should ideally still use a non-NULL callback here so that it can
have better error reporting, but that isn't RC.
smcv
Source: vte2.91
Source-Version: 0.62.0-3
Done: Simon McVittie <[email protected]>
We believe that the bug you reported is fixed in the latest version of
vte2.91, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <[email protected]> (supplier of updated vte2.91 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 30 Sep 2020 16:04:28 +0100
Source: vte2.91
Architecture: source
Version: 0.62.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <[email protected]>
Changed-By: Simon McVittie <[email protected]>
Closes: 941247971422
Changes:
vte2.91 (0.62.0-3) unstable; urgency=medium
.
* Team upload
* d/p/vte.sh-Avoid-warnings-if-shell-is-configured-with-set-u.patch:
* Add patch to fix warnings in shells that use 'set -u'.
Thanks to Marko Mäkelä (Closes: #941247)
* d/p/lib-Abort-when-alloc-returns-nullptr.patch:
Add patch from upstream to make out-of-memory handling more consistent
* d/p/gtk-Allow-passing-null-callback-to-spawn_async.patch:
Add patch from upstream to fix a regression in mssh (Closes: #971422)
Checksums-Sha1:
b30db4319df3fd40a290d1d7073781a34df7c305 2963 vte2.91_0.62.0-3.dsc
ece14170128144c58e7b8eb664f3e63aa148bf6c 24564 vte2.91_0.62.0-3.debian.tar.xz
709b69bb3bc1c3f26f253b505648e7dc4af46385 14224 vte2.91_0.62.0-3_source.buildinfo
Checksums-Sha256:
c557fdcdcc3050ebbcdaada84be636162db82622599a59ee57916a828c08981e 2963 vte2.91_0.62.0-3.dsc
54e3de7a7e760ed6d26adc9a10da1a40aa0f396bab263bbe18ae8341a180ba4e 24564 vte2.91_0.62.0-3.debian.tar.xz
ec5f9b29483df49a276d93dfa858a4bfe27215b04482ea88ff734ff704759065 14224 vte2.91_0.62.0-3_source.buildinfo
Files:
8952b219d5d39781b8265610263caef3 2963 libs optional vte2.91_0.62.0-3.dsc
baa3c0ce230583f0af569adfde839fd6 24564 libs optional vte2.91_0.62.0-3.debian.tar.xz
adaac3218bfea3b5159c21be1f699f6c 14224 libs optional vte2.91_0.62.0-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAl90vvUACgkQ4FrhR4+B
TE+s2BAAiZZ/y4zBEUS1SbS8Fn2rbqmp6dFDWfBkFJRMhDWquF7A42hUeMtW9lEm
US8W7df5QWZdpT2djBEOT8+g+dCV6xEgxKpBgBbsdvkZEdoEtYzvSrLtwT4jW3YM
EDQnlMtwGSU/ePPVdgvbUb4+ldBt5lQRo7fWcrL0yGxTfkdyulrvOCC7qrJjJPRU
UWh1hiIIhonb69c8ymo918a+DCIqmzqC8z9MEm0+ucVXroOvQuIOlyMcGeLLrQHS
dnCIxdK4n/fV+6qs52ZQPMkOZ6H0lxkB2Vcytdi2qHUAmx6sdiFsQ2zECtgm+o5W
lqLYMReEQAsRkcopw3ur1z0amGTROqZqV8DI7Yij5pJl/pQSSP6Xq3pz9UF6p6Rl
rVRXi3VXkT5looSdIRLqNDCzkwSLqLazN8Y/GCIwc8zIpiVVJQBCyTlOUadWj57Q
4efsyMzD+Vwhl+WFd8o6/Q3/ekcjdsv1yoGXsytOS5Rdh9pxlE7PmS1hKgDfgpsb
ffisbfW8Q088BldJluto3ydnMBISRKEnXXHHiLdYD2x3NPk+OQ4lRqbulRZ4/+cV
toVSgfPLzhSCKShzOwUOQRzcG2Ik2wLwemWSxTmPOxSFAaP99cQg6w1kvyQs1Y2B
7G+H+Z2Q7gFA+Zjk//DYcqixap07hjsRRvjPaVMPTDQ1vmXQD04=
=9TAi
-----END PGP SIGNATURE-----
Acknowledgement sent
to Axel Beckert <[email protected]>:
Extra info received and forwarded to list. Copy sent to Debian GNOME Maintainers <[email protected]>.
(Wed, 30 Sep 2020 22:09:05 GMT) (full text, mbox, link).
Control: clone -1 -2
Control: unmerge -2
Control: reopen -2
Control: reassign -2 mssh 2.2-5
Control: severity -2 minor
Control: tag -2 = upstream
Control: retitle -2 mssh: Should use a non-NULL callback in vte_terminal_spawn_async()
Dear Simon,
Simon McVittie wrote:
> I would recommend making mssh use a non-NULL callback *anyway*, because
> it's the only way for vte_terminal_spawn_async() to report errors, which
> any non-trivial vte user should be reporting in some way. Something like
> this should be suitable:
>
> static void
> terminal_spawn_async_cb (VteTerminal *terminal,
> GPid pid,
> GError *error,
> gpointer user_data)
> {
> if (error != NULL)
> g_critical ("Error setting up terminal: %s", error->message);
> else
> g_debug ("Terminal set up, process ID: %d", pid);
> }
>
> (Or whatever error handling mssh wants to do instead of complaining on
> stderr: for example, it might want to emit the session-closed signal
> on errors, or something like that.)
Simon McVittie wrote:
> Control: reassign 970356 libvte-2.91-0 0.62.0-1
[...]
> On Wed, 30 Sep 2020 at 15:22:37 +0100, Simon McVittie wrote:
> > I've reported that upstream.
>
> Now fixed upstream. I'll upload a fixed version soon.
Thanks, much appreciated!
> mssh should ideally still use a non-NULL callback here so that it can
> have better error reporting, but that isn't RC.
I just don't understand why you reassigned that bug then instead of
e.g. cloning or even just simply downgrading it.
Cloning it now and reassigning the clone back — now with severity
minor and a suitable title to keep this at a place where it will be
remembered until its fixed.
P.S.: I have no idea how the BTS behaves when cloning a merged bug. If
I get two cloned bugs in the end, then sorry in advance for that mess.
Will probably have to clean up something afterwards anyways, I just
don't know yet what. Tried to guess as much as possible of what's
needed in the mess we already have here. ;-)
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Acknowledgement sent
to Axel Beckert <[email protected]>:
Extra info received and forwarded to list. Copy sent to Debian GNOME Maintainers <[email protected]>.
(Wed, 30 Sep 2020 22:39:03 GMT) (full text, mbox, link).
Control: unmerge -1
Control: clone -1 -2
Control: merge -1 971422
Control: reopen -2
Control: reassign -2 mssh 2.2-5
Control: severity -2 minor
Control: tag -2 = upstream
Control: retitle -2 mssh: Should use a non-NULL callback in vte_terminal_spawn_async()
Hi again,
Axel Beckert wrote:
> Control: clone -1 -2
> Control: unmerge -2
> Control: reopen -2
> Control: reassign -2 mssh 2.2-5
> Control: severity -2 minor
> Control: tag -2 = upstream
> Control: retitle -2 mssh: Should use a non-NULL callback in vte_terminal_spawn_async()
[...]
> P.S.: I have no idea how the BTS behaves when cloning a merged bug.
It rejects it:
Debian Bug Tracking System wrote:
> > clone -1 -2
> Bug #970356 {Done: Simon McVittie <[email protected]>} [libvte-2.91-0] assertion failed in vte_terminal_spawn_with_fds_async
> Bug #971422 {Done: Simon McVittie <[email protected]>} [libvte-2.91-0] libvte-2.91-0: vte_terminal_spawn_async doesn't accept NULL callback since 0.62
> Failed to clone 970356: Bug is marked as being merged with others. Use an existing clone.
So lets do that whole thing again with even more commands and slightly
different command order. :-)
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Changed Bug title to 'mssh: Should use a non-NULL callback in vte_terminal_spawn_async()' from 'assertion failed in vte_terminal_spawn_with_fds_async'.
Request was from Axel Beckert <[email protected]>
to [email protected].
(Wed, 30 Sep 2020 22:39:08 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.