Would absolutely blow my mind, I would even merge it without multiple approves. :D
And add a new contributors section in the readme with John Carmack at the top.
John Carmack is awesome, but I find this level of deification (of any individual) kinda creepy - it just feels unhealthy. Would you like to be treated that way, in Carmack's position?
I realize that your comment was likely made in jest, but it still bugs me.
I think the joke is that you write a program, and someone well known like Carmack or Linus submits a minor patch, and you from then on say "Linus and I wrote ..."
If the attention bothered him, the simple solution is to create another account under an alias. I do it to keep the worlds apart, and I am not even famous.
Given all that he has accomplished and the influence his work has had on multiple generations of computer and gaming nerds, I don't see the celebrity status as terribly unwarranted.
No one is doing pilgrimages to his house or stealing his garbage or following him around here..
We're just acknowledging that he is an exceptional contributor to our industry, and that his work has inspired a TON of people.
To have someone of that stature contribute to your project is exciting! There's nothing strange or creepy about that, and if people want to celebrate that in their own way like printing a Git commit or something, whatever!
Imagine being an indie film director and having Kathryn Bigelow show up on set one day to give you some notes and feedback on your film. You might frame that piece of paper.
Imagine being a local chef in a restaurant and having Julia Sedefdjian stop by for a meal and compliment your food. You might get a photo to keep on the wall in your kitchen..
Nothing wrong with any of that, I think you are characterizing things to an unwarranted extreme here.
fame and fame admiration is as old as civilization. And yes, using pseudonyms has been used for 100s of years for the same reason. You are complaining about something that is deeply human in nature.
I don't think the comment was fanatical at all, it was a lighthearted joke.
You've had several HN readers suggest your criticism is unwarranted. I agree as well. Seriously, nothing from the OP indicates anything fanatic or out of the ordinary.
Eh, well while I agree, he's far better than Bezos, Musk, or Zuckerberg COMBINED, and look at all the idolatry those guys receive.
Purely in terms of a programmer. Things he's created.
Everyone should be able to have heroes. You don't need to necessarily elevate them to the level of Gods, but John is very readily a video game real life hero.
It's not always necessary to do a strict pre-commit code review system. If you're working on commercial projects you might be used to pair programming or post-commit review (which IIRC isn't actually that risky.)
Of course, I made the comment in jest. But it certainly would be an honor for anyone nonetheless.
(if it did happen for real the most I would do is print out the commit hash with his name next to it :D, because he is one of the people I look up to in CS, others being Knuth and Tarjan among others, I would do the same for them, but then again I don't think they are active open source contributors)
Nonetheless, Carmack is still one of the most impactful programmer of the modern era.
Interesting, yeah it's probably hard for a famous person to connect with you on a real level if you're busy groveling and kissing the ground they walk on.