Calling something a scam can just mean they profit off highly immoral behavior or are inherently deceptive. Loan sharks are scams. Pyramid schemes were scams, even when they weren't illegal.
I've never seen a single timeshare that makes sense in terms of cost to value ratio. There's always a more flexible/cheaper/profitable way to do whatever it is you're trying to do than a timeshare, unless of course you're the one selling it. Very fair to call it a scam.