People who make statements like that are the kind of people you dread will pick up your pull request. You just know you're going to go from maybe spending an hour cleaning up some suggestions to a 3-day philosophical battle to get them to a point where they deign to accept your PR.
Not at all. If the code is decent and shows effort I have no problem. If it's sloppy it shite code.
I really don't have time to care about what my peers think of me. It's work. I don't want to communicate with them outside work. Work is just another mind space that stays at work. I am strict when it comes to code, I expect the same.
I want working maintainable code to enable me to do my job. If people dread submitting a PR because they can't write code with effort, good. I like my ships built strong not weak.
If they fix their problem, good. Trust given, more than happy to salute however time and time they've proven to me they don't.
These developers have proven to me they won't. These are developers who are those who do not fix the issuing code and will just move on to the next problem hacking it to make it work.
If you've never worked with such, then lucky. If this sting for you, time to put more effort in to your work.
No, they really don't. They submit their code. I submit mine. If they have a problem with mine, I'll fix what they have issues with if they are reasonable, why wouldn't I?
Where I work in enterprise your peers change daily. With my role and importance to the company implementing hacky code puts me at risk and so I will of course push back. The people I knew last months may not even work in the company.
The view of I must be a horrible person comes from the Comment OP being angry at me for having a reasonable standards to an Enterprise standard of code. "It works im done. Next please"
If their code isn't up to scratch I will tell them and reject it. The issue I have is lazy developers who implement hacks and don't actually go and fix the code.
I am being made the bad person from someone's angry hospitality. All I was saying is that lazy developers are lazy developers and that I axe their work because it's sloppy and doesn't deserve to be on show.
I'm not to engage further as you're only ever going to repeat yourself in more obnoxious ways, but I will say that if you treat people in real life the way you comment here, you will only ever be tolerated at best. Never respected and never liked.
Even the people you consider peers will abhor that you think and speak like this about people.
